Repository navigation
Update messages that print when starting up Dynmap to denote it as the community edition - #4290
Conversation
…e community edition
|
Agree on showing CE in the log and dropping links we don't run. I'd like to make a suggestion, what about linking to a wiki page (https://github.com/webbukkit/dynmap/wiki ... ) with our channels instead of hardcoding Discord/Reddit? Links might change, and jars stay on servers for a long time. That also settles the Discord question, and Mike's donation links can go there too. IMHO, the first line could be shorter, e.g. |
reusteur73
left a comment
There was a problem hiding this comment.
On the Discord, I'd keep the original one. It already has an active community with admins and moderators, and users expect to find update news there. Splitting support across two servers would only scatter users, especially since Mike doesn't seem to mind us using his. We can still keep ours around, but I don't think it will get much use. Of course, if it ever bothers Mike, we switch to ours.
I also agree with @taranovegor about linking to a GitHub wiki page with our channels instead of hardcoding them. Links can change, but jars stay on servers for years.
Also, one link was missed: spigot/src/main/resources/plugin.yml still has website: "https://www.reddit.com/r/Dynmap/". It could point to https://github.com/webbukkit/dynmap like the Fabric/Forge metadata, or to the wiki page if we go that way.
|
@taranovegor hmm, yes I could make it shorter. I guess the console log isn't the right place to describe the features of the CE branch. I'll change it. @reusteur73 I agree on keeping the original Discord. But in that case, I want to also change the CE modrinth/curseforge pages to point back to the original Discord. If we do the wiki suggestion we can just have the discord and etc. links there. I have wiki edit perms so can create a page for it later. I'll fix the other link you pointed out too. I was only checking the console logs. Didn't expect a reddit link of all things to be somewhere else. |
I want to have a slight differentiation in the startup messages for the CE version, and also to remove links that point to original dynmap stuff that is not being updated.
The reddit/mastodon news link are for the original version, the mastodon in particular won't get updated for CE news (although I will probably update the subreddit going forward).
The donation links also do not go to us. I have no plans to accept donations ever, and I think Mike still deserves support for what he built. But I do want to separate the CE and not print links that aren't ours.
I'm less sure about changing the Discord. Mainly since our discord is devoid of anything right now. And we're still using the original discord to coordinate most of the development on this. Let me know thoughts on that, if I should change the discord support link back.