Repository navigation
Conversation
willymv
marked this pull request as ready for review
November 8, 2026 11:22
taranovegor
reviewed
Nov 18, 2026
taranovegor
left a comment
There was a problem hiding this comment.
A couple of thoughts:
- The condition can be simpler. Could be fold the light check into lit right where it's read:
boolean lit = nbt.getBoolean("isLightOn") || orignbt.contains("starlight.light_version");. - I'm curious what the border between an old chunk and a new one looks like after this. By old I mean a chunk that still gets the generated sky light, and by new one that now uses its real light data. A screenshot of a spot like that would help.
- This isn't Paper-only. Because of the prefix change, Fabric and Forge on 1.20.5 and newer will also start using real skylight instead of the generated one, so it needs testing there too.
Overall the change LGTM. The part that makes me a bit cautious is that it changes how every map renders.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes two causes for Dynmap to incorrectly run the generateSky() method in the GenericMapChunkCache class.
// Assume skylight is only trustworthy in a lit stateif ((!hasLitState) || (!lit)) {hasLight = false;}// If no light, do simple generateif (!hasLight) {//Log.info(String.format("generateSky(%d,%d)", x, z));bld.generateSky();}Issues
hasLitState
if (status.equals(litState))to always fail and for hasLitState to stay false.lit
Fixes
Example image

Notes