Skip to content

Fix/context menu theme - #744

Open
ronakmaheshwari wants to merge 8 commits into
webpack:mainfrom
ronakmaheshwari:fix/context-menu-theme
Open

ronakmaheshwari wants to merge 8 commits into
webpack:mainfrom
ronakmaheshwari:fix/context-menu-theme

Conversation

@ronakmaheshwari

@ronakmaheshwari ronakmaheshwari commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Context:
Follow-up to #690. The context menu still had hard-coded colors, and disabled items were low contrast in both themes

What changed:
This applies the same CSS changes that were already discussed and reviewed there based on the work done by @theEquinoxDev, so it should be easy to merge:

  1. Menu background and border use --bg-primary and --border-color
  2. Disabled items use --text-secondary
  3. Hover and click behavior is unchanged

Summary by CodeRabbit

  • New Features
    • The plugin uses Webpack’s infrastructure logger when available, aligning its logging with Webpack’s infrastructureLogging configuration.
  • Deprecations
    • logLevel is deprecated in favor of Webpack’s infrastructureLogging configuration.
  • Style
    • Context menus now use theme-based background and border colors.
    • Disabled menu items use the secondary text color and appear more subdued.

@changeset-bot

changeset-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0932a15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
webpack-bundle-analyzer Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ronakmaheshwari

Copy link
Copy Markdown
Contributor Author

@evenstensberg can u just take a look

@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1aa83cee-6037-4e4d-8726-41fc5a28c26c
📥 Commits

Reviewing files that changed from the base of the PR and between 0ebe1e5 and 0932a15.

⛔ Files ignored due to path filters: 1
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing: 3
  • .changeset/use-webpack-infrastructure-logger.md
  • client/components/ContextMenu.css
  • client/components/ContextMenuItem.css

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The context menu container now uses CSS variables for its background and border. Disabled context menu items now use the secondary text color and have reduced opacity. A changeset records the use of Webpack’s infrastructure logger when available and the deprecation of logLevel in favor of infrastructureLogging.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 0932a

No actionable behavior or installation risk was identified; the context-menu styling uses tokens available in both themes. The PR is ready to merge subject to normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: fixing the context menu theme. This matches the CSS changes for background, border, and disabled-item colors.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant