Feature/replace formik - #1309
Merged
Merged
Conversation
Phase 2 of the Formik migration: RoutineForm, DayForm, SessionForm, SessionLogsForm and ProgressionForm. Array rows render from a subscription on the array value since array-mode fields only follow the length. Forms with async defaults are keyed by them, which replaces enableReinitialize. Also moves the measurement and nutrition forms to the synchronous validator slot introduced in the previous commit. Adds tests for validation display, the day type select, the impression buttons, single set removal and the operation switch.
Collaborator
|
coverage: 83.041% (+0.3%) from 82.704% — feature/replace-formik into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces formik which seems to be unmaintained with tanstack forms