Repository navigation
Pull requests: Fixed more files loading slower with every page and the file tree divider ending early - #183
Merged
Conversation
…to the footer Each page of a large pull request loaded slower than the one before: Forgejo removes the loader and appends the next one after the diff, and the element before a changed last child is restyled with everything inside it, so every page restyled all files loaded so far. An empty element now stands between the diff and the loader. Every page also pushed the whole file list into the tree's data again; only files not listed yet are added now. In a 360 file pull request a page now takes about 300ms instead of growing to almost 2s. The next page starts loading four screens before the end, and a load that finds the link busy is retried shortly instead of after five seconds. The divider between the file tree and the files ends at the footer, as on GitHub, instead of above the page's bottom margin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a pull request's Files changed tab:
Before and after
The bottom of the Files changed tab of a pull request with one file, at 1280px in the dark theme.
Release notes
Area: Descriptionwith a listed areaBranches: Fixed ...feature,change,bug,dependencies, orskip-changelogbugonly for a bug that shipped in a release; a fix for a bug that only existed ondevisskip-changelogmajoradded when admins must act on upgrade, for example a new minimum Forgejo version.github/release-notes.md, if admins need themChecks
bun checkandbun vitest(581 tests) pass. Load times measured in the dev preview on the 360 file pull request ofacme/design-system.🤖 Generated with Claude Code