Skip to content

Pull requests: Fixed more files loading slower with every page and the file tree divider ending early - #183

Merged
whereareiam merged 1 commit into
devfrom
fix/pull-files-divider-loading
Nov 14, 2026
Merged

whereareiam merged 1 commit into
devfrom
fix/pull-files-divider-loading

Conversation

@whereareiam

@whereareiam whereareiam commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

On a pull request's Files changed tab:

  • Loading more files no longer slows down page by page. Each loaded page took longer than the one before (in a 360 file pull request, from about 0.4s up to almost 2s per page, with the browser frozen for up to a second). Forgejo removes the loading row after every page and appends the next one right after the diff, and the browser then restyled every file loaded so far. An empty element now stands between the diff and the loading row, so each page restyles only itself; every page of that pull request now takes about 300ms. Every page also added the whole file list to the file tree's data again (360 files became 3,240 entries); a page now adds only files not listed yet.
  • The next files start loading earlier, four screens before the end instead of about two, and a load that finds Forgejo busy with another one is retried shortly instead of after five seconds.
  • The divider between the file tree and the files runs down to the footer, as on GitHub, instead of ending above the page's bottom margin.

Before and after

The bottom of the Files changed tab of a pull request with one file, at 1280px in the dark theme.

Before After
Files changed before Files changed after

Release notes

  • The title follows Area: Description with a listed area
  • The title describes the effect in the past tense, for example Branches: Fixed ...
  • Exactly one label: feature, change, bug, dependencies, or skip-changelog
  • bug only for a bug that shipped in a release; a fix for a bug that only existed on dev is skip-changelog
  • major added when admins must act on upgrade, for example a new minimum Forgejo version
  • Upgrade steps or warnings added to .github/release-notes.md, if admins need them

Checks

  • Tests added or updated
  • Checked in the dev preview at desktop width in dark mode

bun check and bun vitest (581 tests) pass. Load times measured in the dev preview on the 360 file pull request of acme/design-system.

🤖 Generated with Claude Code

…to the footer

Each page of a large pull request loaded slower than the one before: Forgejo
removes the loader and appends the next one after the diff, and the element
before a changed last child is restyled with everything inside it, so every
page restyled all files loaded so far. An empty element now stands between the
diff and the loader. Every page also pushed the whole file list into the tree's
data again; only files not listed yet are added now. In a 360 file pull
request a page now takes about 300ms instead of growing to almost 2s.

The next page starts loading four screens before the end, and a load that
finds the link busy is retried shortly instead of after five seconds.

The divider between the file tree and the files ends at the footer, as on
GitHub, instead of above the page's bottom margin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@whereareiam whereareiam added the bug Fixes a bug that shipped in a release label Nov 14, 2026
@whereareiam
whereareiam merged commit 802e5f0 into dev Nov 14, 2026
6 of 7 checks passed
@whereareiam
whereareiam deleted the fix/pull-files-divider-loading branch November 14, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes a bug that shipped in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant