Repository navigation
Document that readOnly is only a control in the relation configuration - #269
Open
LukeTowers wants to merge 3 commits into
Open
LukeTowers wants to merge 3 commits into
LukeTowers wants to merge 3 commits into
Conversation
`relationRender('comments', ['readOnly' => true])` reads as a way to forbid writes, but the value goes to the browser and comes back with each relation AJAX request, so the client decides whether it returns at all. It can only ever make a relation more restricted than its configuration says. The configuration key, and `relationExtendConfig()`, are the forms that are enforced.
Also documents what a read only relation actually does now that the handlers refuse, and the preview-mode contract form widgets have to honour in their own AJAX handlers.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
applyExtraConfig() keeps only recordUrl and recordOnClick, so the value is dropped in both directions rather than restricting the render further.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relationRender('comments', ['readOnly' => true])reads as a way to forbid writes, but the value goes to the browser and comes back with each relation AJAX request, so the client decides whether it returns at all. It can only ever make a relation more restricted than its configuration says. The configuration key, andrelationExtendConfig(), are the forms that are enforced.Also documents what a read only relation actually does now that the handlers refuse, and the preview-mode contract form widgets have to honour in their own AJAX handlers.