Repository navigation
Support Laravel 13 - #9
Merged
Merged
Conversation
The site cannot upgrade to Laravel 13 while this package pins laravel/framework ^12 and the l12-only torchlight fork. Widens the constraints to ^12|^13, switches to the fork's l13-compatibility branch, and moves dev tooling to Pest 4/5 and Testbench 10/11.
Torchlight v0.6.2 ships Laravel 13 support, so the laravel-shift fork and its VCS repository are no longer needed. Laravel 13 can refuse to unserialize cached objects (cache.serializable_classes), which turned the cached menu Collection into __PHP_Incomplete_Class; caching the plain array avoids that.
ph7jack
changed the title
The Table docs page was removed in 2023 but its menu entry stayed, so the sidebar linked to /components/table, which returns a 500 (view not found), and a reject list papered over it for prev/next links. The entry and the reject list are gone, pages missing from the menu now get no prev/next links, and a test asserts every menu page has a view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site can't move to Laravel 13 while this package pins
laravel/framework^12 and the l12-only torchlight fork.^12.0|^13.0.torchlight/torchlight-laravel^0.6.2 (released with Laravel 13 support) and drops the laravel-shift fork repository.Collection. Laravel 13 addscache.serializable_classes; when it isfalse(the 13.x skeleton default) the cached Collection came back as__PHP_Incomplete_Classand every docs page threw a TypeError. Covered by a new test.actions/checkoutto v7.The suite passes on Laravel 12.69 (Pest 4.7) and Laravel 13.35 (Pest 5.3).