Repository navigation
fix: backfill transport failures and snapshot check per-database folder (T-1742, T-1743) - #301
Merged
Merged
Conversation
…back (T-1742) A plain ProviderCallError (HTTP 429/5xx, network, configuration) took the T-1722 "one attempt, continue" path meant for malformed replies. During a 70-minute provider outage on 2026-10-23 that burned 459 window attempts and 459 never-settled reservations until the 1,200/day extract cap deferred the cohort, and the extra attempts would have exhausted the cohort's repair allowance on the retry. Only ProviderOutputError keeps the continue path; any other ProviderCallError restores the attempt, releases the reservation and stops the run so the scheduled task retries later. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…_dir (T-1743) The weekly VACUUM INTO copy is written to <base>/<db-stem>-<hash>/, but the installed review listed only the base and reported "no snapshot files found" next to a one-day-old snapshot. Without an explicit snapshot_dir the check now probes vacuum_dir_for(config.db) and falls back to the base. ROADMAP: AO-2 is activated since 2026-10-22 (T-1695); note the shared daily caps finding. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily operational review 2026-10-23: two bounded owned regressions.
T-1742 backfill — a plain
ProviderCallError(HTTP 429/5xx, network, configuration) took the T-1722 "one attempt, continue" path meant for malformed replies. During a 70-minute provider outage that burned 459 window attempts and 459 never-settled reservations until the 1,200/day extract cap deferred the cohort; the extra attempts would then have exhausted the cohort's repair allowance on the retry. OnlyProviderOutputErrorkeeps the continue path; any otherProviderCallErrorrestores the attempt, releases the reservation and stops the run so the scheduled task retries later. Red-first testtest_transport_failure_gives_back_attempt_and_reservation_and_stops_the_run; the T-1722/T-1723 tests are unchanged.T-1743 review —
check_snapshot_dirlisted only the base folder while the weeklyVACUUM INTOcopy is written to<base>/<db-stem>-<hash>/, so the installed review reported "no snapshot files found" next to a one-day-old snapshot. Without an explicitsnapshot_dirthe check now probesvacuum_dir_for(config.db)and falls back to the base. Red-first testtest_snapshot_dir_probes_the_per_database_folder; existing explicit-folder tests unchanged.ROADMAP: AO-2 activation line synced (activated 2026-10-22, T-1695) with the shared-daily-caps finding.
Checks: ruff clean;
tests/test_dreaming_backfill_cli.py40 passed,tests/test_operational_review.py27 passed,tests/test_public_demo.py2 passed; release truth regenerated and--checkok; contract witness ok (2 code files with 2 test witnesses).🤖 Generated with Claude Code