Repository navigation
fix(session): Reject non-user access tokens in session cookies - #99
Merged
Merged
Conversation
verifyAccessToken now requires sid and auth_time, a sub_profile that is absent or user, and no sub_type, so other token types signed by the same environment key do not authenticate a session. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
Original prompt from madison.packer
|
Contributor
Devin Review🟢 Devin Review found nothing to fix · View findings |
Contributor
[High impact] The PR appears safe to merge. SummaryThe PR limits session cookies to verified user access tokens.
No actionable new issues were found. Tests were inspected but not run.
|
withAuth decoded the cookie's access token without verifying it, relying on a parent authkitLoader that may run in parallel. It now returns no user unless verifyAccessToken passes. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyAccessTokeninsession.tsonly ranjwtVerify, which checks the signature,exp, andiss. It never checked that the token is a user session access token, so other token types signed by the same environment key could authenticate a session.This matches
hasRequiredAccessTokenClaimsin@workos-inc/node.sub_profileis optional on user access tokens, so a token without it is still accepted. Rejected tokens go down the existing invalid-token path, where the loader tries a refresh, the same as when verification fails.withAuthpreviously decoded the cookie's access token and only checkedexp, relying on a parentauthkitLoaderto have verified it. Parent and child loaders run in parallel, so it now verifies the token itself:withAuthstill can't refresh, so a token that fails verification returns no user until the parent loader refreshes the session. The JWKS comes from the module-levelgetJWKS()cache, so this adds a signature check per call, not a fetch.Tests: the new
should not accept a verified access token with %scoverssub_profile: ai_agent,sub_type: authkit, a missing or stringauth_time, and a missing or numericsid. All 6 cases fail without thesession.tschange.withAuth'sshould return NoUserInfo when the access token fails verificationfails without theauth.tschange. The existingjwtVerifymocks now resolve a user-shaped payload.Link to Devin session: https://app.devin.ai/sessions/7e123fc2545a49c282b043a4abd58f70
Open in Devin Desktop: https://app.devin.ai/desktop/session/7e123fc2545a49c282b043a4abd58f70?variant=devin
Requested by: @m0tzy