Repository navigation
Set up the database server in the foreground - #321
Merged
Merged
Conversation
The MySQL setup runs in the background alongside setup-php and the Ghostscript install. The action unpacks its binaries with the system tar, which fails to load libpcre2-8.so.0 while apt upgrades that library. Let the background step fail softly and retry it in the foreground once the other setup steps are done. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UWTd5qGVcfTHmYNMmJgdGu
Replaces the retry from the previous commit. The action unpacks its binaries with the system tar, which fails to load libpcre2-8.so.0 while setup-php or the Ghostscript install upgrade that library with apt. Running it before those steps instead of in the background avoids the race altogether. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UWTd5qGVcfTHmYNMmJgdGu
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Setup MySQL Server" step in the Behat workflow fails intermittently, for example in https://github.com/wp-cli/entity-command/actions/runs/43994625716/job/133743569506:
The step runs in the background (
background: true) alongside setup-php and, for some packages, the Ghostscript apt install.shogo82148/actions-setup-mysqldownloads its own binaries but unpacks them with the systemtar, which loadslibpcre2-8.so.0. setup-php can upgrade that library through apt, and iftarstarts while the upgrade is in progress, the library is briefly missing.This change stops running the step in the background. It already comes before setup-php and the Ghostscript install, so it now finishes before any apt work starts. The comments are updated to match: the step's comment now explains why it isn't run in the background, and the
wait-allcomment now only refers to the Windows Chocolatey step, the one background step left.The trade-off is that MySQL legs take longer, by about the time the database setup used to overlap with the PHP and Composer setup. SQLite legs skip this step and aren't affected.
Generated by Claude Code
Summary by CodeRabbit