Skip to content

Set up the database server in the foreground - #321

Merged
swissspidy merged 2 commits into
mainfrom
claude/happy-heisenberg-lh9196
Nov 17, 2026
Merged

swissspidy merged 2 commits into
mainfrom
claude/happy-heisenberg-lh9196

Conversation

@swissspidy

@swissspidy swissspidy commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

The "Setup MySQL Server" step in the Behat workflow fails intermittently, for example in https://github.com/wp-cli/entity-command/actions/runs/43994625716/job/133743569506:

/usr/bin/tar: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory

The step runs in the background (background: true) alongside setup-php and, for some packages, the Ghostscript apt install. shogo82148/actions-setup-mysql downloads its own binaries but unpacks them with the system tar, which loads libpcre2-8.so.0. setup-php can upgrade that library through apt, and if tar starts while the upgrade is in progress, the library is briefly missing.

This change stops running the step in the background. It already comes before setup-php and the Ghostscript install, so it now finishes before any apt work starts. The comments are updated to match: the step's comment now explains why it isn't run in the background, and the wait-all comment now only refers to the Windows Chocolatey step, the one background step left.

The trade-off is that MySQL legs take longer, by about the time the database setup used to overlap with the PHP and Composer setup. SQLite legs skip this step and aren't affected.


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the automated functional test workflow to run MySQL setup in sequence and clarified which dependencies the wait step covers.

The MySQL setup runs in the background alongside setup-php and the
Ghostscript install. The action unpacks its binaries with the system
tar, which fails to load libpcre2-8.so.0 while apt upgrades that
library. Let the background step fail softly and retry it in the
foreground once the other setup steps are done.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UWTd5qGVcfTHmYNMmJgdGu
Replaces the retry from the previous commit. The action unpacks its
binaries with the system tar, which fails to load libpcre2-8.so.0
while setup-php or the Ghostscript install upgrade that library with
apt. Running it before those steps instead of in the background
avoids the race altogether.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UWTd5qGVcfTHmYNMmJgdGu
@swissspidy
swissspidy requested a review from a team as a code owner November 17, 2026 17:14
Copilot AI balanced review requested due to automatic review settings November 17, 2026 17:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The functional workflow no longer runs MySQL setup in the background. The wait-step comment now refers to Windows dependencies, and the wait-all configuration is unchanged.

Changes: Functional Workflow Setup

Layer / File(s) Summary
Workflow setup and wait behavior
.github/workflows/reusable-functional.yml
MySQL setup is no longer configured as a background step. Its comment describes a potential libpcre2 conflict during system package upgrades. The wait-step comment refers to Windows dependencies, and wait-all is unchanged.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: schlessera

Merge Risk: Minimal · up to d075a

This workflow change runs MySQL setup in the foreground to avoid intermittent tar and libpcre2 failures during apt upgrades. The only expected effect is longer MySQL CI legs. No merge-blocking risk was found.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added bug Something isn't working scope:testing labels Nov 17, 2026
@swissspidy
swissspidy merged commit 216bb65 into main Nov 17, 2026
18 of 19 checks passed
@swissspidy
swissspidy deleted the claude/happy-heisenberg-lh9196 branch November 17, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working scope:testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants