Repository navigation
fix(core): keep the login cookie in Safari on http://localhost - #2675
Merged
Merged
Conversation
josephfusco
marked this pull request as ready for review
October 20, 2026 14:08
Merged
josephfusco
added
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2131
Safari discards
Securecookies on plain-HTTP localhost (WebKit bugs 218980 and 281149), so outside production builds the refresh-token cookie now leavesSecureoff for plain HTTP requests to a loopback host; production builds always set it. Checked with Playwright WebKit 27.2 against Chromium, but not in real Safari.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with researching WebKit's cookie handling on localhost, writing the fix and tests, and comparing WebKit and Chromium in Playwright.