Repository navigation
Prepare StackFolio for WordPress.org submission - #31
Merged
Merged
Conversation
Clears the two Plugin Check warnings and one likely review question before submitting StackFolio to WordPress.org. ## #28 Match the readme.txt plugin name to the plugin header - `readme.txt` is titled `=== StackFolio ===`, matching `Plugin Name: StackFolio`, so the generated slug is `stackfolio`. - The GitHub README keeps the full title. After approval, #24 switches the header and readme.txt to "StackFolio – Photo & Video Album Gallery". ## #29 Remove the Domain Path header - There is no `languages/` folder; WordPress.org serves translations for the `stackfolio` text domain. ## #30 Use lightGallery's default licence key - Removes the `licenseKey: 'GPLv3'` override from `assets/js/stackfolio.js`. lightGallery is used under GPLv3, the same as StackFolio. The only effect is a console warning. ## What happens on merge The zip changes, so this releases **v1.0.1**, the version to submit. Closes #28 Closes #29 Closes #30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the two Plugin Check warnings and one likely review question before submitting StackFolio to WordPress.org.
#28 Match the readme.txt plugin name to the plugin header
readme.txtis titled=== StackFolio ===, matchingPlugin Name: StackFolio, so the generated slug isstackfolio.#29 Remove the Domain Path header
languages/folder; WordPress.org serves translations for thestackfoliotext domain.#30 Use lightGallery's default licence key
licenseKey: 'GPLv3'override fromassets/js/stackfolio.js. lightGallery is used under GPLv3, the same as StackFolio. The only effect is a console warning.What happens on merge
The zip changes, so this releases v1.0.1, the version to submit.
Closes #28
Closes #29
Closes #30