Repository navigation
Fix sideways drag in the album editor and video thumbnails - #34
Merged
Merged
Conversation
Fixes the two problems found while testing v1.0.1 on a staging site, before submitting to WordPress.org. ## #32 Dragging photos sideways in the album editor doesn't reorder them - `assets/css/stackfolio-admin.css`: the media list uses floated tiles instead of flexbox. jQuery UI sortable only sorts sideways when items float. With flexbox it treated the list as vertical and ignored left/right drags. ## #33 Uploaded videos without a poster look like a copy of the album cover - `includes/class-stackfolio-album.php`: only the video's own image is used as its poster. Without one, the player shows the video directly, and the thumbnail strip shows a new neutral icon, `assets/images/video-thumb.svg`. ## Testing on staging (WordPress Playground, WordPress 7.1, PHP 8.3, Elementor, WP_DEBUG on) On v1.0.1 from the release zip: - **Migration from Album Station:** 3 albums, categories, videos and the API key moved; an unrelated `album` post left alone. - **YouTube playlist, with the YouTube API mocked:** correct request (key and playlist ID); private and deleted videos skipped; videos before photos as migrated; video plays; result cached (1 API call across reloads). - **Uploaded MP4:** recorded H.264 MP4 uploaded, added through the media picker, plays in the lightbox with controls and inline playback. - **Album editing:** media picker, remove, save. - **Block:** filters, lightbox, Escape returns focus. - **Shortcode** and legacy `[feature_album]`. - **Elementor:** legacy `as-gallery` page, editor re-render, new widget. - **Mobile 375px:** one column, no horizontal scroll, lightbox fits. - **Uninstall:** settings removed, albums kept. - **Debug log:** no StackFolio notices or warnings. On this branch (exact package copy): - A sideways drag now reorders (`13,14,15,22` → `22,13,14,15`) and saves. - The video shows directly with the neutral thumbnail and plays. - Debug log clean. - PHPCS, PHPStan, unit tests and CSS lint pass locally. ## What happens on merge The zip changes, so this releases **v1.0.2**, the version to submit. Closes #32 Closes #33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two problems found while testing v1.0.1 on a staging site, before submitting to WordPress.org.
#32 Dragging photos sideways in the album editor doesn't reorder them
assets/css/stackfolio-admin.css: the media list uses floated tiles instead of flexbox. jQuery UI sortable only sorts sideways when items float. With flexbox it treated the list as vertical and ignored left/right drags.#33 Uploaded videos without a poster look like a copy of the album cover
includes/class-stackfolio-album.php: only the video's own image is used as its poster. Without one, the player shows the video directly, and the thumbnail strip shows a new neutral icon,assets/images/video-thumb.svg.Testing on staging (WordPress Playground, WordPress 7.1, PHP 8.3, Elementor, WP_DEBUG on)
On v1.0.1 from the release zip:
albumpost left alone.[feature_album].as-gallerypage, editor re-render, new widget.On this branch (exact package copy):
13,14,15,22→22,13,14,15) and saves.What happens on merge
The zip changes, so this releases v1.0.2, the version to submit.
Closes #32
Closes #33