Repository navigation
feat: add cached setup-wright Action - #1
Merged
Merged
Conversation
Move the composite Action from wrightkit/wright into its own repository so consumers call wrightkit/setup-wright@v1 and get a major tag independent of Wright release refs. This reverses the earlier non-goal of a separate repository. Behavior matches the reviewed in-repo version, except that the installed version check now matches the whole version rather than a substring, with a test. Refs wrightkit/wright#717
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the cached
setup-wrightcomposite Action out ofwrightkit/wright(supersedingwrightkit/wright#867) into this repository. Target call:uses: wrightkit/setup-wright@v1.Decision: the owner split the Action out because
wrightkit/wright/.github/actions/setup-wright@<release-ref>is an awkward call path, and consumers need a stable major tag independent of Wright's release refs. This reverses the earlier non-goal inwrightkit/wright#717. It is recorded inREADME.md.What is here
action.ymlandscripts/setup-wright.sh: same contract as the reviewed feat(ci): add cached setup-wright Action wright#867 version. Exact cache key (no restore prefix), SHA-256 verified before save and use, corrupt cache never executed, no secrets or write token.scripts/test-setup-wright.sh: the 22 helper tests plus one new test (see below).actionlint,shellcheck, helper tests, and a smoke job that usesuses: ./on Linux, macOS and Windows with Wright0.29.0. It installs twice, requirescache-hit == trueon the second install (skipped on fork PRs), checkswright --version, and runswright check..github/workflows/release.ymluses release-please (the org's pattern for small repos, as inwrightkit/skills). Merging the Release PR createsvX.Y.Z; the same job then moves the major tag (v1). The tag move uses the built-in token, so there is no extra secret. No tag or release is created by this PR.README.md, repo-localAGENTS.md, and a narrowCODEOWNERS.Changes from wrightkit/wright#867
verify-cacheandinstallnow matches the whole version, so1.2.30no longer passes for1.2.3. The new test fails under the old substring check.latest, which also resolves review note 4.Verification
actionlintandshellcheck -S warningare clean.Not verified here
release.yml(release-please bootstrap withinitial-version1.0.0 and an empty manifest, and the major-tag move) can only be proven by a real release. Perrelease-engineering.md, the release topology is not established until one release completes.@v1ref waits for the first release.Refs #3