Skip to content

docs: cube sizes 2 to 15 in README, guides and page description - #71

Merged
wstein merged 10 commits into
mainfrom
docs/app-size-range-15-docs
Nov 18, 2026
Merged

wstein merged 10 commits into
mainfrom
docs/app-size-range-15-docs

Conversation

@wstein

@wstein wstein commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Updates reader-facing size statements to 2..15 and adds a test that keeps them in line with the size constant.

Changes:

  • README, index.html and package.json descriptions, docs/user-guide.md, docs/color-profiles.md: 2x2 to 15x15.
  • docs/parity.md: no upper bound; user-guide scramble sentence: cubes of 4x4 and larger.
  • docs/user-guide.md: net-picture import 2x2 to 15x15 (feat(vision): net pictures and guided centers for cubes up to 15x15 #68).
  • docs/user-guide.md: real camera photos exist for 2x2 to 5x5 and 7x7; 6x6 and 8x8 to 15x15 are synthetic only (8, 9, 10, 12, 15 measured); tilted faces on large cubes lose or shift the grid.
  • docs/scanner.md, src/cube/Parity.res comment: "5x5 and larger", "6x6 and larger", "4x4 and larger".
  • test/fixtures/README.md: removes the "imported 8x8" wording.
  • test/docSizeRange.test.ts: fails when README, descriptions, user guide, color profiles, parity or scanner state a range "AxA to NxN", "up to NxN", "sizes 2 to N" or a pair "AxA and NxN" with N below the CUBE_SIZES maximum.

Tests: docSizeRange 9/9 (red before the edits, 5 mutations red); typecheck, lint, format:check, build, typos, git diff --check pass. Local full vitest: 47 red only from Git LFS pointers (same as the base); CI test green.
Not changed: docs/cubelab-fingerprint.md (correct on main), AGENTS.md:89 (owner rule "2x2-7x7 behavior/tests"), docs/viewer-migration-inventory.md ("sizes 2-7" is the recorded inventory state).

Blocker: none.

🤖 Generated with Claude Code

Base automatically changed from feat/app-size-range-15-profiles to main November 18, 2026 15:04
@wstein
wstein force-pushed the docs/app-size-range-15-docs branch from 3861118 to c095b8c Compare November 18, 2026 15:43
@wstein
wstein changed the base branch from main to feat/app-orbit64-v2-only November 18, 2026 15:43
@wstein
wstein added this pull request to stack #74 November 18, 2026 16:41
Base automatically changed from feat/app-orbit64-v2-only to main November 18, 2026 16:41
wstein and others added 5 commits November 18, 2026 17:41
…d package description

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…arity

Net-picture import stays 2 to 7 and camera detection on 8 and larger is
marked as not measured.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…size

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…7 measured on synthetic images only

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein
wstein force-pushed the docs/app-size-range-15-docs branch from ed9c70d to d9b9bd7 Compare November 18, 2026 16:41
@wstein

wstein commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Review: FINDINGS head=d9b9bd74f2cc565cc15c3449328c5b687bc5b093 patch-id=6ea2190961ae4ab091f7d4bed48f58d9956774dd pr=71

  1. blocking docs/user-guide.md:5-8: camera sentence does not match its sources. Real camera fixtures exist for 2x2 too (test/fixtures/cube-2x2-*, used by gridAlignmentRealCrops); 6x6 has only a synthetic fixture and is in neither list; the synthetic measurement covered 8, 9, 10, 12 and 15, not 11/13/14; on tilted faces at n>=9 the grid shifts and colors are read wrong (live accuracy down to 0.01), not only "detected less often".
    Fix: real photos of 2x2-5x5 and 7x7; 6x6 and 8x8-15x15 synthetic only (8, 9, 10, 12, 15 measured); upright faces read correctly, tilted faces on large cubes are dropped or read shifted, so hold the face upright.
  2. blocking docs/scanner.md:16-17: "5x5-7x7 faces" and "For 6x6 and 7x7, an additional outer-edge check": code applies it to every size from 6 (GridAlignment.res:624 gridSize >= 6, outerRatios from 5). Fix: "5x5 and larger", "6x6 and larger".
  3. nit test/docSizeRange.test.ts: patterns only catch ranges starting at 2x2 and "up to"; "4x4-7x7" (the pre-PR form in parity.md and user-guide.md) and "2 to 7" pass undetected; docs/scanner.md is not in RANGE_FILES.
  4. nit stale 7x7 bounds outside docs: src/cube/Parity.res:420 comment "4x4-7x7"; AGENTS.md:89 "2x2-7x7" (owner rule); docs/viewer-migration-inventory.md "sizes 2-7" (inventory).
  5. nit PR text "full vitest pass": locally 47 failures (LFS pointers, identical at base); CI test passes with LFS. Say so.
    Checks at head: npm ci 0; typecheck, lint, format:check, build, typos 0; git diff --check 0 lines; docSizeRange 8/8 (7/8 fail on base docs); vitest 1775 pass / 47 fail, base 1767 / 47, same failing set.
    Mutations: 10; doc 15->7 (3 files, 3 spellings), "up to 7x7", maxCubeSize 14 fail as meant; dropping "through" or the filter hides a regression (load-bearing); 2 survivors in nit 3.
    CI run 44350183205 (CI: test, typos) success, attempt 1. Commits: Conventional, Co-Authored-By, no CRLF, no session links; committer GitHub from the base change.

wstein and others added 5 commits November 18, 2026 19:20
…measured

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… sizes

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein

wstein commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Review: CLEAR head=e482a0b25055104dc7cdf32916db7cb8368ab54d patch-id=1dc00b04d9b1ea55cbb31f1d26bc894b43ed422e pr=71
Round 2 (delta d9b9bd7..e482a0b, 5 new commits). Both blocking findings of round 1 are resolved.
1 resolved: docs/user-guide.md:5-9 matches the sources: camera fixtures 2x2 2, 3x3 6, 4x4 2, 5x5 8, 7x7 3 (meta.json source); synt-6x6 only for 6x6; measurements cover 8, 9, 10, 12, 15; upright 8x8 8/9, 15x15 9/9; grid loss or shift under tilt from 9x9 (measurements finding 3).
2 resolved: docs/scanner.md:16-17 matches GridAlignment.res:624 (gridSize >= 6) and outerRatios (from 5).
Nits 3-5 of round 1 resolved or named in the PR text (AGENTS.md:89, viewer-migration-inventory.md, cubelab-fingerprint.md).
nit test/docSizeRange.test.ts PAIR: a true pair statement such as "Real 6x6 and 7x7 faces have wider outer rows." in a listed file fails the test; NUMBER_RANGE also matches any "2-N" or "2 to N" text. Reword or allow-list if it bites.
Checks at head: npm ci 0; typecheck, lint, format:check, build, typos 0; git diff --check 0 lines; docSizeRange 9/9; vitest 1776 pass / 47 fail, failing set identical to base 11cd659 (Git LFS pointers).
Mutations: 8. Red as meant: parity "4x4-7x7", user guide "2 to 7", scanner "6x6 and 7x7" and "5x5-7x7", color profiles "sizes 2..7", RANGE_END reading the start. Load-bearing: removing scanner.md from RANGE_FILES or disabling PAIR hides a regression.
CI run 44379760238 (CI: test, typos) success, attempt 1. PR text 20 lines, one Blocker line. New commits: Conventional, Co-Authored-By, author and committer Werner Stein, no CRLF, no session links.

@wstein
wstein marked this pull request as ready for review November 18, 2026 19:56
@wstein
wstein merged commit 564d8b4 into main Nov 18, 2026
2 checks passed
@wstein
wstein deleted the docs/app-size-range-15-docs branch November 18, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant