Skip to content

docs(agents): state the supported size range as 2x2-15x15 - #75

Merged
wstein merged 1 commit into
mainfrom
docs/agents-size-range-15
Nov 18, 2026
Merged

wstein merged 1 commit into
mainfrom
docs/agents-size-range-15

Conversation

@wstein

@wstein wstein commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Owner decision 2026-11-18: the supported cube size range is 2x2-15x15. This PR updates the one range statement in AGENTS.md and puts the file under the documented-range test.

Changes

  • AGENTS.md line 89 ("Preserve its capture, ... existing 2×2–7×7 behavior/tests"): old 2×2–7×7, new 2×2–15×15. Reason: the rule describes the app's supported range; CUBE_SIZES max is 15.
  • test/docSizeRange.test.ts: AGENTS.md added to RANGE_FILES (the test already exists on main).

Checked and unchanged

  • AGENTS.md has no other match for the old bound (grep for 7 ?[x×] ?7, up to 7, 2.{1,4}7: one hit, line 89). No solver, fixture or history statement in the file names a 7 bound, so the solver range 2..7 is not touched.
  • The rule says only "behavior/tests"; no test matrix or "all sizes" duty to verify.

Tests

  • npx vitest run test/docSizeRange.test.ts: red before the AGENTS.md change (1 failed, 9 passed), green after (10 passed).
  • Mutation: restoring 2×2–7×7 fails "AGENTS.md states no range that ends below 15".
  • npm run format:check, typos, git diff --check: clean.

Not verified: full npm test, e2e (docs and a doc test only).

Blocker: none.

🤖 Generated with Claude Code

The preservation rule named 2x2-7x7. The app, viewer and capture
detection support 2..15 (CUBE_SIZES). Add AGENTS.md to the documented
size range test.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein

wstein commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Review: CLEAR head=3d7af32b0978f42734ee9a8a1e01e7c2f94c49f5 patch-id=d3d79757385ebe7d6301ef35cd5a7edc70714ba0 pr=75
Round 1, independent review of the exact head (git archive copy, base main 3ecb788).
Primary sources: CubeSizeRange.res maxCubeSize=15, NetImage.res maxSize=15, fingerprint v2 above 7, user guide 2x2-15x15. AGENTS.md: no other old bound (grep: line 89 only).
The rule asks to preserve existing behavior/tests; 8..15 behavior and synthetic tests exist, so the statement holds.
1 low nit test/docSizeRange.test.ts:24-35 (unchanged code): an em dash range "2×2—7×7" and words "two to seven" in AGENTS.md pass the test (mutations survived). Open.
2 low nit test/docSizeRange.test.ts:12: with AGENTS.md listed, a future true statement such as "solver engines 2..7" in AGENTS.md fails the test; needs an allowlist then. Open.
Runs: vitest docSizeRange 10 passed; format:check 0; typos 0; git diff --check 0; CI run 44392352395 success (test, typos).
Mutations: 8 of 10 fail "AGENTS.md states no range that ends below 15" (7x7, "2x2 to 7x7", "2..7", "sizes 2 to 7", "up to 7×7", 14×14, spaced x, suffix); removing AGENTS.md from RANGE_FILES with 7x7 passes (9 passed), so the new line carries the check.
Full npm test: 47 failed in 3 files with "SOI not found" (LFS pointer JPGs in the archive copy); not caused by this diff, CI test job green.
Commit: Conventional, Co-Authored-By present, author and committer match git config, no session links. PR text 21 lines, one Blocker line, Generated last.
Not checked: e2e.

@wstein
wstein marked this pull request as ready for review November 18, 2026 20:52
@wstein
wstein merged commit 9c4a29b into main Nov 18, 2026
2 checks passed
@wstein
wstein deleted the docs/agents-size-range-15 branch November 18, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant