Repository navigation
Reject whitespace in compressed MultiIndex level names - #677
Closed
nawaaaaaAaar wants to merge 1 commit into
Closed
nawaaaaaAaar wants to merge 1 commit into
nawaaaaaAaar wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
+ Coverage 85.78% 87.09% +1.30%
==========================================
Files 13 16 +3
Lines 2364 3355 +991
Branches 183 313 +130
==========================================
+ Hits 2028 2922 +894
- Misses 303 387 +84
- Partials 33 46 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #570.
Reproduction and fix
A MultiIndex level such as
"north south"is written intocompress="north south lon", which is then parsed as three coordinate names. Reject whitespace-containing level names before producing an ambiguous encoded result and tell callers to rename the levels.The validation is deliberately limited to levels of the selected MultiIndexes. Unrelated variable names containing spaces remain allowed.
Regression coverage
git diff --check.AI-assisted implementation and tests. Documentation explains the restriction; no broad restriction on NetCDF variable names is introduced.