Repository navigation
Recognize CDM vertical direction metadata - #678
Open
nawaaaaaAaar wants to merge 1 commit into
Open
nawaaaaaAaar wants to merge 1 commit into
nawaaaaaAaar wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
+ Coverage 85.78% 87.14% +1.35%
==========================================
Files 13 16 +3
Lines 2364 3352 +988
Branches 183 313 +130
==========================================
+ Hits 2028 2921 +893
- Misses 303 385 +82
- Partials 33 46 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #316.
Scope
The existing criteria already recognize CDM
_CoordinateAxisTypevalues. The missing narrow case is_CoordinateZisPositive: the documented"up"/"down"values should identify a vertical coordinate just as CFpositivedoes.Add that criterion and document exactly what is recognized. This is not a claim to implement CDM coordinate transforms,
_CoordinateAxes, or the entire conventions system, so it does not automatically close #316.Regression coverage
git diff --check.Convention reference: https://docs.unidata.ucar.edu/netcdf-java/current/userguide/coord_attr_conv.html
AI-assisted implementation and regression tests. The broader convention scope is left to maintainers.