Skip to content

Remove unused Mac App Store server entitlement #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blessdyb merged 1 commit into from
Oct 26, 2026
Merged

Remove unused Mac App Store server entitlement #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions FlowlightExtension/FlowlightExtension-AppStore.entitlements
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,5 @@
</array>
<key>com.apple.security.network.client</key>
<true/>
<key>com.apple.security.network.server</key>
<true/>
</dict>
</plist>
2 changes: 1 addition & 1 deletion project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ settings:
CODE_SIGN_STYLE: Automatic
ENABLE_HARDENED_RUNTIME: YES
MARKETING_VERSION: "0.15.5"
CURRENT_PROJECT_VERSION: "50"
CURRENT_PROJECT_VERSION: "52"
configs:
AppStore:
DEVELOPMENT_TEAM: 38RJUJHKZS
Expand Down
31 changes: 31 additions & 0 deletions scripts/check_app_store_product.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,47 @@
set -euo pipefail

app=${1:?usage: check_app_store_product.sh /path/to/Flowlight.app}
repo=$(cd "$(dirname "$0")/.." && pwd)
contents="$app/Contents"
extension="$contents/PlugIns/com.flowlight.app.filter.appex"
app_binary="$contents/MacOS/Flowlight"
extension_info="$extension/Contents/Info.plist"
app_entitlements="$repo/Flowlight/Flowlight-AppStore.entitlements"
extension_entitlements="$repo/FlowlightExtension/FlowlightExtension-AppStore.entitlements"

fail() {
echo "App Store product check failed: $*" >&2
exit 1
}

plist_true() {
[ "$(/usr/libexec/PlistBuddy -c "Print :$2" "$1" 2>/dev/null)" = true ]
}

# The Store build disables HTTPS inspection: it neither installs a root certificate nor starts the local proxy.
# Nothing in this product listens for inbound connections, so a server entitlement on either executable is a
# least-privilege regression and will also stop automated App Review before the submission can proceed.
if /usr/libexec/PlistBuddy -c 'Print :com.apple.security.network.server' "$app_entitlements" >/dev/null 2>&1; then
fail "Store app declares network.server even though Store inspection is disabled"
fi
if /usr/libexec/PlistBuddy -c 'Print :com.apple.security.network.server' "$extension_entitlements" >/dev/null 2>&1; then
fail "Store extension declares network.server but has no inbound listener"
fi
plist_true "$app_entitlements" com.apple.security.network.client || fail "Store app is missing network.client"
plist_true "$extension_entitlements" com.apple.security.network.client || fail "Store extension is missing network.client"

ruby -ryaml -e '
project = YAML.safe_load(File.read(ARGV.fetch(0)), aliases: true)
expected = {
"FlowlightAppStore" => "Flowlight/Flowlight-AppStore.entitlements",
"FlowlightStoreExtension" => "FlowlightExtension/FlowlightExtension-AppStore.entitlements"
}
expected.each do |target, path|
actual = project.dig("targets", target, "settings", "base", "CODE_SIGN_ENTITLEMENTS")
abort "#{target} uses #{actual.inspect}, expected #{path}" unless actual == path
end
' "$repo/project.yml" || fail "Store targets use the wrong entitlement files"

[ -x "$app_binary" ] || fail "missing app executable"
[ -d "$extension" ] || fail "missing embedded content-filter app extension"
[ ! -d "$contents/Library/SystemExtensions" ] || fail "contains a direct-distribution system extension"
Expand Down
Loading