Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
clean_terminal_output()currently treats erase-right as clearing the whole line and moving the cursor to column zero. This can drop the final status from captured progress output:The default
CSI Kand explicit-zeroCSI 0 Kerase from the current cursor to the end of the line. Text before the cursor and the cursor position should stay intact. Reference: https://xfree86.org/current/ctlseqs.html (Erase in Line).Change
Handle erase-right separately from newlines, truncate only the suffix, and recognize the explicit-zero form. Add seven regression test methods covering both forms, including progress updates, backspaces, later writes, carriage returns and newlines. No new runtime dependency.
Other erase modes, terminal-width wrapping, ANSI color handling and Unicode cell-width emulation are outside this change.
Verification
CPython 3.10.12 on Linux:
flake8,compileallandgit diff --checkpassed.Python 2, other Python 3 versions, PyPy, Windows, macOS, the Sphinx build and remote CI were not run locally. No independent human QA results have been received.
AI-assisted implementation and tests. Base:
6758ac61f906cd8528682003070a57febe4ad3cf.