Repository navigation
feat(run): record the model's call id on each tool call - #73
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Records the model's id for each tool call on its tool call row, so a host can pair a recorded call with the approval decision that named it, exactly.
run.MetadataCallID = "call_id": the metadata key, documented as the id the tool result and an approval decision name the call by (not unique across a run; a later response may reuse it).arguments_amended,amended_by) are merged into the same map instead of replacing it.publicGenerationText), so its rows carry no call_id; the existing transcript privacy tests stay green.foundry's agent step bridge already reads this key (xraph/foundry#59), so its run trace pairs calls with tool approvals by id once foundry requires a cortex release with this change.
Tests
New tests for a straight run (sync and streaming), approve, reject, amend (markers kept), reclaim replay and an empty id.
go test ./...passes in the root module, including the sqlite, postgres and mongo store suites; golangci-lint v2.12.2 (Go 1.26) reports 0 issues;go mod tidychanges nothing.