feat!: Acorn 5 only (v2.0.0) - #101
Merged
Merged
Conversation
|
Coverage report for commit: 8ef8148 Summary - Lines: 9.89% | Methods: 7.27%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
rivanuff
marked this pull request as ready for review
September 4, 2026 08:25
rivanuff
requested review from
Rovasch,
ShunLuk,
SimonvanWijhe,
dtakken,
ictbeheer and
mvdhoek1
and
a lite review from Copilot
September 4, 2026 08:25
There was a problem hiding this comment.
🟡 Changes recommended
Composer constraints don’t currently enforce the stated Acorn 5/Laravel 12-only support boundary, which can allow unsupported installs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR prepares the package for a v2.0.0 breaking release by narrowing supported dependency versions to match the stated “Acorn 5 / Laravel 12 only” direction and removing now-unneeded Composer audit ignores.
Changes:
- Removes the
config.audit.ignoreblock fromcomposer.json. - Restricts
jgrossi/corcelto^9.0(dropping multi-major support).
File summaries
| File | Description |
|---|---|
| composer.json | Removes Composer audit ignore configuration and tightens the Corcel version constraint. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
19
to
23
| "require": { | ||
| "php": ">=8.2", | ||
| "jgrossi/corcel": "^7.0 || ^8.0 || ^9.0", | ||
| "jgrossi/corcel": "^9.0", | ||
| "spatie/laravel-data": "^4.5" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops Acorn 4 support; Acorn 5 / Laravel 12 only.
jgrossi/corcel→^9.0(was^7.0 || ^8.0 || ^9.0)Will be released as v2.0.0. Draft — no tag yet.