feat: Acorn 5 / Laravel 12 support (retains Acorn 4 / Laravel 10 & 11) - #43
Merged
Conversation
rivanuff
changed the title
rivanuff
marked this pull request as ready for review
September 1, 2026 14:43
rivanuff
requested review from
Rovasch,
ShunLuk,
SimonvanWijhe,
dtakken,
ictbeheer and
mvdhoek1
and
a lite review from Copilot
and removed request for
Copilot
September 1, 2026 14:43
There was a problem hiding this comment.
🔵 Needs a closer look
The PR broadens multiple major-version dependency constraints and CI matrix behavior in ways that warrant a human verification pass (especially around version pairing and real-world install/test results).
Pull request overview
This PR updates the package’s dependency constraints and CI configuration to support Acorn 5 / Laravel 12 while retaining compatibility with Acorn 4 / Laravel 10 & 11, aligning sibling yard/* dependencies accordingly.
Changes:
- Broadened Composer constraints for Acorn, Corcel, and dev tooling (Testbench/Pest/PHPStan-related packages).
- Updated CI to run a Laravel 10/11/12 test matrix across PHP 8.2 and 8.3 via the reusable workflow.
- Stopped treating
composer.lockas a tracked artifact (gitignored it) and removed related automation configuration.
File summaries
| File | Description |
|---|---|
| README.md | Updates requirements wording and adds Packagist dependency badges. |
| composer.json | Widens runtime and dev dependency constraints to span Laravel/Acorn versions; bumps yard/data. |
| .gitignore | Ignores composer.lock. |
| .github/workflows/run-tests.yml | Passes PHP/Laravel matrix inputs to the reusable test workflow. |
| .github/workflows/composer-lock-diff.yml | Removes the Composer lock diff workflow (file deleted). |
| .github/dependabot.yml | Removes Dependabot Composer update configuration. |
Review details
- Files reviewed: 5/7 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+8
to
+9
|  | ||
|  |
rivanuff
force-pushed
the
feat/acorn5
branch
from
September 2, 2026 12:09
b6c7235 to
ac63ac4
Compare
BREAKING CHANGE: drops Laravel 10 support; requires roots/acorn ^5.0 and PHP >=8.2.
… phpstan-wordpress 2)
rivanuff
force-pushed
the
feat/acorn5
branch
from
September 2, 2026 12:11
ac63ac4 to
4700c26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acorn 5 / Laravel 12 support — backward compatible
Adds support for Acorn 5 / Laravel 12 while retaining Acorn 4 / Laravel 10 & 11. This is a backward-compatible change.
Target release:
v1.1.0(minor).composer.jsonconstraints so the package installs on Laravel 10, 11 and 12 (Acorn 4 or 5 where applicable), and widened the dev toolchain (orchestra/testbench,pestphp/pest,larastan/larastan,szepeviktor/phpstan-wordpress) to span those versions.yard/*dependencies aligned to their minor releases (e.g.yard/data ^1.6).