Skip to content

fix(skill): fail closed on response errors and invalid ledger filters (1.1.48) - #146

Merged
yunze7373 merged 1 commit into
mainfrom
codex/skill-1.1.48-error-handling
Oct 24, 2026
Merged

yunze7373 merged 1 commit into
mainfrom
codex/skill-1.1.48-error-handling

Conversation

@yunze7373

Copy link
Copy Markdown
Member

Fix three standalone Skill failures: malformed successful HTTP responses now exit nonzero; Cloud Skill detail reads propagate component errors instead of returning a successful empty list; ledger amount filters reject non-finite values and reversed ranges before network access. Release candidate: XMemo Skill 1.1.48. CLI version and pins are unchanged.

Validation:

  • Focused Cloud Skill and error-boundary tests: 24/24 passed.
  • npm run lint and package build/dry-run passed.
  • Full local suite: 750 passed, 1 skipped, 1 failed. The failure is the unchanged CLI pin gate: pin 1.1.45 is older than existing skill-v1.1.47. The test and every imported release-check source are unchanged from base; isolated rerun reproduces it.
  • Live read-only smoke: 13 passed, 9 write operations skipped, 2 ledger reads denied by the existing credential's missing ledger_read scope. These are not counted as passing live ledger validation.
  • Live Cloud Skill list and show passed, including an empty component array.
  • Review policy adapter returned not_required for this human task under reviewer_only; this is not a Reviewer approval.

New regression coverage checks empty/non-JSON 2xx bodies, HTTP auth/server error classes, component failures and invalid shapes in terminal/JSON modes, zero-request rejection of invalid ledger filters, and successful decimal/zero filter serialization.

@yunze7373
yunze7373 merged commit 704b6be into main Oct 24, 2026
7 checks passed
@yunze7373
yunze7373 deleted the codex/skill-1.1.48-error-handling branch October 24, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant