Repository navigation
fix(skill): fail closed on response errors and invalid ledger filters (1.1.48) - #146
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three standalone Skill failures: malformed successful HTTP responses now exit nonzero; Cloud Skill detail reads propagate component errors instead of returning a successful empty list; ledger amount filters reject non-finite values and reversed ranges before network access. Release candidate: XMemo Skill 1.1.48. CLI version and pins are unchanged.
Validation:
New regression coverage checks empty/non-JSON 2xx bodies, HTTP auth/server error classes, component failures and invalid shapes in terminal/JSON modes, zero-request rejection of invalid ledger filters, and successful decimal/zero filter serialization.