Skip to content

release: ignore untracked files in cleanliness guard - #148

Merged
yourconscience merged 1 commit into
mainfrom
fix/release-untracked-guard
Aug 23, 2026
Merged

release: ignore untracked files in cleanliness guard#148
yourconscience merged 1 commit into
mainfrom
fix/release-untracked-guard

Conversation

@yourconscience

@yourconscience yourconscience commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Summary by Sourcery

Bug Fixes:

  • Update the release cleanliness guard to ignore untracked files while continuing to reject tracked uncommitted changes.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@sourcery-ai

sourcery-ai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the release script’s cleanliness guard to ignore untracked files while still failing when there are uncommitted changes to tracked files, and clarifies the associated error message.

File-Level Changes

Change Details Files
Relax the release cleanliness check to ignore untracked files while still preventing releases with uncommitted changes to tracked files.
  • Replace the blanket git status --porcelain emptiness check with a filtered check that only considers lines matching tracked-file states via grep '^[ MARC]'
  • Update the failure message to explicitly indicate the presence of uncommitted changes rather than a generic 'working tree not clean' wording
scripts/release.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. If the new filter is wrong, the release can proceed while untracked files are present, potentially producing a release from a workspace that was not intended to be clean. Reverting restores the guard for future releases, but any tag or release artifact created before the revert would need to be handled separately.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yourconscience
yourconscience merged commit 5bf92b1 into main Aug 23, 2026
5 checks passed
@yourconscience
yourconscience deleted the fix/release-untracked-guard branch August 23, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant