npm: publish as scoped @your_conscience/dotagents - #149
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR migrates npm publishing and installation guidance from the unscoped dotagents package to @your_conscience/dotagents, keeping release duplicate detection and all documented install commands consistent with the new package name. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="npm/package.json" line_range="2" />
<code_context>
{
- "name": "dotagents",
+ "name": "@your_conscience/dotagents",
"version": "0.0.0-dev",
"description": "Dotfiles for your AI agents: one ~/.agents repo synced to every coding agent.",
</code_context>
<issue_to_address>
**issue (broader_impact):** After the package is renamed to `@your_conscience/dotagents`, the CLI's postinstall recovery message still instructs users to run `npm rebuild -g dotagents`; that command targets the old unscoped package and does not reliably rebuild the installed scoped package.
**Triggers:** When the postinstall download fails or the installed binary is missing.
**Suggested fix:** Update the recovery command to `npm rebuild -g @your_conscience/dotagents` and update any other user-facing references to the old package name.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 1 finding to address first, and if the scope or package identity is wrong, the release workflow can publish versions under a name that users cannot install as expected, and those published artifacts are not removed by reverting this change. The issue is bounded and repairable by deprecating or republishing the affected package versions.
Blocking findings: npm/package.json:2
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "dotagents", | |||
| "name": "@your_conscience/dotagents", | |||
There was a problem hiding this comment.
issue (broader_impact): After the package is renamed to @your_conscience/dotagents, the CLI's postinstall recovery message still instructs users to run npm rebuild -g dotagents; that command targets the old unscoped package and does not reliably rebuild the installed scoped package.
Triggers: When the postinstall download fails or the installed binary is missing.
Suggested fix: Update the recovery command to npm rebuild -g @your_conscience/dotagents and update any other user-facing references to the old package name.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c96c14670c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "dotagents", | |||
| "name": "@your_conscience/dotagents", | |||
There was a problem hiding this comment.
Update stale operational commands to the scoped name
After this rename, two user-facing commands still target the unscoped package: npm/bin/dotagents.js:13 recommends npm rebuild -g dotagents when the downloaded binary is missing, and scripts/release.sh:41 uses npm view dotagents version to verify a release. The local npm 11.4.2 help defines both arguments as package specs, so these commands act on a different package and cannot rebuild or verify @your_conscience/dotagents; update both as part of the rename.
AGENTS.md reference: AGENTS.md:L50-L50
Useful? React with 👍 / 👎.
Summary by Sourcery
Publish dotagents as the scoped
@your_conscience/dotagentsnpm package and align release checks and installation documentation with the new name.Enhancements:
@your_conscience/dotagentsand update installation guidance accordingly.CI:
Documentation: