Skip to content

feat: add unified search support - #453

Open
cameronapak wants to merge 1 commit into
mainfrom
feat/unified-search
Open

cameronapak wants to merge 1 commit into
mainfrom
feat/unified-search

Conversation

@cameronapak

@cameronapak cameronapak commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add the existing unified-search endpoint to core and React hooks, with public types and release metadata. Consumers can fetch top verse references and topics in one request; existing paginated BibleReader search stays unchanged.

UI re-exports the core function and types. No visual UI changes.

Verification

Build, typecheck, lint, tree-shaking, and 1,038 unit tests pass (two optional live tests skipped). New coverage uses mocked HTTP and provider-backed hooks, not live API calls.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Adds unified search through SearchClient.searchUnified, the standalone searchUnified function, and useUnifiedSearch.

  • One search request returns top Bible references and related topics.
  • React apps can load unified search results through a hook.

Review was based on source inspection; tests were not rerun.

Diagram

sequenceDiagram
  participant App
  participant Hook as useUnifiedSearch
  participant Core as SearchClient.searchUnified
  participant API as Search API
  App->>Hook: Query, version, languages, options
  Hook->>Core: Load through useApiData
  Core->>Core: Validate inputs
  Core->>API: GET /v1/search-unified
  API-->>Core: Verse references, topics, correction hints
  Core->>Core: Validate and map response
  Core-->>Hook: SearchUnifiedResponse
  Hook-->>App: data, loading, error, refetch
Loading

Reviews (1) · Last reviewed commit: "feat: add unified search to core and Rea..." · Reviewed by Greptile

@cameronapak cameronapak self-assigned this Oct 20, 2026
@camrun91

Copy link
Copy Markdown
Collaborator

@cameronapak we can remove this PR right?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants