Repository navigation
feat: add unified search support - #453
Open
cameronapak wants to merge 1 commit into
Open
cameronapak wants to merge 1 commit into
cameronapak wants to merge 1 commit into
Conversation
Collaborator
|
@cameronapak we can remove this PR right? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the existing unified-search endpoint to core and React hooks, with public types and release metadata. Consumers can fetch top verse references and topics in one request; existing paginated BibleReader search stays unchanged.
UI re-exports the core function and types. No visual UI changes.
Verification
Build, typecheck, lint, tree-shaking, and 1,038 unit tests pass (two optional live tests skipped). New coverage uses mocked HTTP and provider-backed hooks, not live API calls.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Adds unified search through
SearchClient.searchUnified, the standalonesearchUnifiedfunction, anduseUnifiedSearch.Review was based on source inspection; tests were not rerun.
Diagram
Reviews (1) · Last reviewed commit: "feat: add unified search to core and Rea..." · Reviewed by Greptile