Namespace plugin storage keys per authenticated user - #138
Open
taban03 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed changes
context.storage is plugin-scoped and shared by every user of the
plugin across local/cluster/HA back-ends. The storage router bound
get/set/delete/getAll/setAll/deleteAll directly to it with no
ownership check, so any authenticated user could read another user's
entries, overwrite them, or wipe the entire plugin namespace via
DELETE /.
Every key is now namespaced as
${req.username}:${key}beforereaching context.storage. GET/POST/DELETE / are scoped to only the
caller's own prefixed keys instead of operating on the whole
plugin-wide dictionary; GET/POST/DELETE /:key operate on the caller's
own namespaced key. A guard middleware rejects requests with no
authenticated username.
This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments