Repository navigation
Audit: enforce local GNN pin contract and record PDF provenance - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and branch base
estate/audit-fixesbranches fromorigin/mainat a1fda4d (PR #25), not from the unmerged migration branch.workflows/gnn-fep-migrationand its commit 3d11832 are untouched; nognn.importerscutover is included.Audit items
docs/INTEGRATION.mdand the distinctdocs/AGENTS.mdunchanged in the final diff. The authoritative sidecar validator resolves docs entries relative to.aii, so adding.aii/would incorrectly resolve.aii/.aii/docs/INTEGRATION.md. The initial path edit was reverted before landing.meta.updatedrecords this review. Source-kernel validation reportsOK: . has a valid .aii sidecar, completeness 100%.blockference.gnn.load_pinnow requires a JSON object,gnn-importer-pin/v1,v5.0.3, and a full 40-hex revision, with field-namedValueErrors. CI provisioning uses that same reader in its already-installed locked package environment instead of two independent unvalidated JSON loads. Added acceptance and negative regression cases for missing/unknown schema, missing/mismatched tag, missing/short/nonhex revision, and a non-object record. Shared-reader adoption remains intentionally deferred: estate pin v5.0.3 (8f293d9b) does not containgnn.importers, per the GNN-FEP staged-adoption contract. No reader was vendored and the pin was not bumped.docs/_generated/gate-timings.jsonimports a real render observation and retains earlier successes/failures inruns; the PDF remains ignored. Artifact:docs/_build/manuscript/activeblockference.pdf, 262701 bytes, SHA-25677ee9b6ef9c83cc8b26ce5bd9130baa851ce5168b5d4207f3e2b3e16ce884f88, source commit2193be7b0be3fc429f4a8d159d4b96b249b12060. Updated existing gate/GNN docs and regenerated metrics.Local gate evidence
GitHub Actions is billing-locked; local front-door arms are the gate.
scripts/release_check.py --arm lint --arm types: green (Ruff; mypy 30 source files).--arm test-full: 103 passed, 0 skipped, 91.02% coverage (90% floor).--arm docs: green, including final generated metrics and link/anchor checks.--arm gnn --gnn-runtime /private/tmp/gnn-rt-503/bin/python: green, real v5.0.3 parser, no failures, canonical orientation, consistency 1.0.--arm render: green, Pandoc + XeLaTeX, provenance captured above.Pre-existing build-output contamination, preserved rather than suppressed
Two initial full-suite runs failed only because notebook validation recursively found this ignored migration experiment notebook:
docs/_build/gnn-fep-migration/tmp/activeblockference-gnn-pin-o1t0l45k/docs/cognitive_phenomena/meta-awareness/computational_phenomenology_of_mental_action.ipynb.Before moving anything:
git check-ignore -v <that path>returned.gitignore:29:docs/_build/and the exact path.git ls-files docs/_build/gnn-fep-migrationreturned no output.With authorization, temporarily moved the gitignored, untracked directory
docs/_build/gnn-fep-migrationto/tmp/activeblockference-gnn-fep-migration-audit-preserved. The unmodified full-suite front door then passed all 103 tests. Restored the directory to its exact original location afterwards for the blocked migration experiment. No tracked content was moved or changed, and there was no notebook-test suppression or validator scope change. The failed receipts are retained. Follow-up outside this PR: notebook discovery should respect ignored build directories.Authoritative sidecar generation
Ran:
All five canonical files were written, and the scoped
git diff --exit-codereported zero diff. No rendered sidecar documents were hand-edited. Ran the same source-kernelaii_platform.aii_sidecar.validate . --completeness: valid, 100%.