Skip to content

Audit: enforce local GNN pin contract and record PDF provenance - #26

Merged
docxology merged 3 commits into
mainfrom
estate/audit-fixes
Nov 12, 2026
Merged

docxology merged 3 commits into
mainfrom
estate/audit-fixes

Conversation

@docxology

Copy link
Copy Markdown
Collaborator

Scope and branch base

estate/audit-fixes branches from origin/main at a1fda4d (PR #25), not from the unmerged migration branch. workflows/gnn-fep-migration and its commit 3d11832 are untouched; no gnn.importers cutover is included.

Audit items

  1. Sidecar path: audit claim rejected. Kept docs/INTEGRATION.md and the distinct docs/AGENTS.md unchanged in the final diff. The authoritative sidecar validator resolves docs entries relative to .aii, so adding .aii/ would incorrectly resolve .aii/.aii/docs/INTEGRATION.md. The initial path edit was reverted before landing. meta.updated records this review. Source-kernel validation reports OK: . has a valid .aii sidecar, completeness 100%.
  2. Interim local pin enforcement. blockference.gnn.load_pin now requires a JSON object, gnn-importer-pin/v1, v5.0.3, and a full 40-hex revision, with field-named ValueErrors. CI provisioning uses that same reader in its already-installed locked package environment instead of two independent unvalidated JSON loads. Added acceptance and negative regression cases for missing/unknown schema, missing/mismatched tag, missing/short/nonhex revision, and a non-object record. Shared-reader adoption remains intentionally deferred: estate pin v5.0.3 (8f293d9b) does not contain gnn.importers, per the GNN-FEP staged-adoption contract. No reader was vendored and the pin was not bumped.
  3. Fresh PDF provenance through producer. A passing render arm records PDF repository-relative path, exact byte size, SHA-256, and source commit. Regression tests cover the recorded artifact and missing-PDF rejection. docs/_generated/gate-timings.json imports a real render observation and retains earlier successes/failures in runs; the PDF remains ignored. Artifact: docs/_build/manuscript/activeblockference.pdf, 262701 bytes, SHA-256 77ee9b6ef9c83cc8b26ce5bd9130baa851ce5168b5d4207f3e2b3e16ce884f88, source commit 2193be7b0be3fc429f4a8d159d4b96b249b12060. Updated existing gate/GNN docs and regenerated metrics.

Local gate evidence

GitHub Actions is billing-locked; local front-door arms are the gate.

  • scripts/release_check.py --arm lint --arm types: green (Ruff; mypy 30 source files).
  • --arm test-full: 103 passed, 0 skipped, 91.02% coverage (90% floor).
  • --arm docs: green, including final generated metrics and link/anchor checks.
  • --arm gnn --gnn-runtime /private/tmp/gnn-rt-503/bin/python: green, real v5.0.3 parser, no failures, canonical orientation, consistency 1.0.
  • --arm render: green, Pandoc + XeLaTeX, provenance captured above.
  • Executed both exact workflow pin-read commands locally: expected repository URL and full pinned revision returned.

Pre-existing build-output contamination, preserved rather than suppressed

Two initial full-suite runs failed only because notebook validation recursively found this ignored migration experiment notebook:
docs/_build/gnn-fep-migration/tmp/activeblockference-gnn-pin-o1t0l45k/docs/cognitive_phenomena/meta-awareness/computational_phenomenology_of_mental_action.ipynb.

Before moving anything:

  • git check-ignore -v <that path> returned .gitignore:29:docs/_build/ and the exact path.
  • git ls-files docs/_build/gnn-fep-migration returned no output.

With authorization, temporarily moved the gitignored, untracked directory docs/_build/gnn-fep-migration to /tmp/activeblockference-gnn-fep-migration-audit-preserved. The unmodified full-suite front door then passed all 103 tests. Restored the directory to its exact original location afterwards for the blocked migration experiment. No tracked content was moved or changed, and there was no notebook-test suppression or validator scope change. The failed receipts are retained. Follow-up outside this PR: notebook discovery should respect ignored build directories.

Authoritative sidecar generation

Ran:

PYTHONPATH=/Users/friedman/Documents/Git/gitvault/Username/ActiveInferenceInstitute/Private/aii-platform/src \
/Users/friedman/Documents/Git/gitvault/Username/ActiveInferenceInstitute/Private/InstituteOS/.venv/bin/python \
  -m aii_platform.aii_sidecar docs <ActiveBlockference checkout> --overwrite

All five canonical files were written, and the scoped git diff --exit-code reported zero diff. No rendered sidecar documents were hand-edited. Ran the same source-kernel aii_platform.aii_sidecar.validate . --completeness: valid, 100%.

@docxology
docxology merged commit 9f17b5e into main Nov 12, 2026
0 of 4 checks passed
@docxology
docxology deleted the estate/audit-fixes branch November 12, 2026 15:52
@docxology
docxology restored the estate/audit-fixes branch November 12, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant