Repository navigation
fix(cli): stop quoting plain run prompt arguments - #1561
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: f8661666-f3d9-4cb8-b88b-be0f24764927) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
Plain `run` prompts are joined with spaces instead of having each space-containing argument wrapped in quotes, which reached the model and hid corrections from learn capture. `--command` keeps its quoting for `$1`/`$2` expansion. Closes #1560 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
14b3002 to
d6a3279
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: d8fb4709-8e1e-4a15-9e86-0af0b789e848) |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gemini-4-argon · Input: 85.2K · Output: 1.2K · Cached: 272.4K Review guidance: REVIEW.md from base branch |
Issue for this PR
Closes #1560
Type of change
What does this PR do?
altimate-code run "Fix the failing test"sent the prompt to the model wrapped in literal quotes, because run quoted every argument containing a space. That quoting only matters for--command, whose template splits arguments on quotes. One side effect: learn capture missed corrections sent this way ("No, ..."does not read as a correction).Was → now: plain prompts are joined with single spaces and keep any quotes the user typed.
--commandis unchanged. The change is one helper,joinRunMessage, marked as an upstream fix.How did you verify your code works?
--commandquoting and escaping, and a one-argument correction that the learn classifier now recognizes. The old quoted form is not recognized.Cost side effects
None.
Screenshots / recordings
N/A (CLI text).
Checklist
🤖 Generated with Claude Code
Note
Low Risk
Narrow CLI message-formatting change with tests;
--commandquoting is unchanged.Overview
Fixes how
runbuilds the user message from CLI arguments so plain prompts are no longer wrapped in literal double quotes when an argument contains spaces.The handler now uses exported helper
joinRunMessage(args, command): non-command runs join arguments with single spaces and leave user-typed quotes unchanged;--commandruns keep the previous behavior (quote space-containing args and escape embedded quotes) for$1/$2parsing.Adds
run-message.test.tscovering plain prompts, command quoting parity, and that one-argument corrections likeNo, use to_utc.still matchcorrectionReasonfor learn capture.Reviewed by Cursor Bugbot for commit d6a3279. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Fixes
altimate-code runsending plain prompts wrapped in literal double quotes, which reached the model and broke learn capture so corrections likerun --session <id> "No, use to_utc."were never recognized.--commandbehavior is unchanged: arguments containing spaces are still quoted and embedded quotes escaped exactly as before.joinRunMessageas an exported helper and a new test suite covering plain prompts,--commandquoting, and correction classification.Written for commit d6a3279. Summary will update on new commits.