Repository navigation
Conversation
2104e39 to
2871955
Compare
2871955 to
6032694
Compare
| curators_permission = Permission(harvester_admin_access_action, | ||
| clc_sync_admin_access_action) | ||
|
|
||
| harvester_admin_access_permission = Permission(harvester_admin_access_action) |
There was a problem hiding this comment.
last thing that came to my mind, sorry for not spotting it on the first iteration:
the name might be slightly misleading, because in fact we do not give the harvester the admin permission (or action) and that is not the intention - I would simply go with harvester_access_action and harvester_access_permission - removing the admin references from the names. We don't want the harvester to be an admin in the system.
There was a problem hiding this comment.
including renaming the actual action (Line 12 - action_factory("harvester-admin-access-action")) ?
because then we have to revoke that one and assign the new action ("harvester-access-action") to the harvester user in all envs? how do you do this to make sure it's done on deployment?
There was a problem hiding this comment.
as discussed on the stand up, the action name itself was not updated only the code references
fc88ae9 to
1b5cf87
Compare
7f3085f to
d5d0b51
Compare
* Allow admins and INSPIRE harvester to replace files without a new version
d5d0b51 to
086ed66
Compare
closes enable file replace feature without versioning for admins and harvester only #991
for deployment it needs https://gitlab.cern.ch/cds-team/cds-rdm-openshift/-/merge_requests/32