Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the analytical angle estimate and make prescribed trace placement, physical slit dispersion and collimator/camera magnification explicit. Simulation and diagnostics can consume the same wavelength-dependent mapping.
Part 06/29 of the Caltech review series. Review the diff against
review/xs-05-detector-readouts; the final destination ismain.Merge after series 05: scopesim.
Review focus: scopesim/optics/echelle.py; EchelleSpectralTraceList; EchelleSpectralEfficiency.
Validation: The combined geometry/calibrated-trace boundary passes 135 checks; includes echelle geometry and trace-coordinate tests.
Source commits/snapshots:
acfa5a71,aefbe60d,87d6f581,4c64fe55,f2c9c01c,4c10ecdf,e2cefad8 (configured optical-table values).Use a merge commit to preserve the stack ancestry and pinned commits. After this merges, retarget the next PR in this repository to its default branch. Do not squash/rebase an earlier stack entry without rebuilding its descendants and dependency pins.