Repository navigation
[09/29] Integrate slit illumination and detector pixels with pre-slit ADC shifts - #29
Merged
Yashvi-Sharma merged 5 commits intoNov 5, 2026
Conversation
Yashvi-Sharma
approved these changes
Nov 5, 2026
Yashvi-Sharma
left a comment
Yashvi-Sharma
left a comment
Collaborator
There was a problem hiding this comment.
Lots of changes in optical train and FOV which may not align with upstream design.
…zimager-throughput [27/29] Apply imaging branch throughput before wavelength integration
…detector-operating-points [10/29] Model configured avalanche noise and warn at detector exposure limits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate continuous PSF illumination over the physical slit and finite wavelength cells over detector pixels. Apply ADC displacement before slit clipping. Keep double-precision accumulation and restrict reuse to the evaluated physical inputs.
Part 09/29 of the Caltech review series. Review the diff against
review/xs-08-spectral-integrals; the final destination ismain.Merge after series 08: scopesim.
Review focus: scopesim/optics/fov_utils.py; spectral_trace_list_utils.py; PSF and ADC effects.
Validation: 249 combined numerical/operating-point checks passed, with three inherited expected failures. Includes slit edges, off-slit light, photon integrals, ADC order, finite cells and mutable-input cache checks.
Source commits/snapshots:
b6f31f6a,0701bb57,dcb05181,f9dccd8f,fa2598b7,ee4e4e67,e9f4b77a,0b15a616,089852a6,8a43ec43,a0495f72,8727eafe,aef3a53d.Use a merge commit to preserve the stack ancestry and pinned commits. After this merges, retarget the next PR in this repository to its default branch. Do not squash/rebase an earlier stack entry without rebuilding its descendants and dependency pins.