Repository navigation
Move from pipenv to uv - #285
Merged
Merged
Conversation
Replace Pipfile and Pipfile.lock with pyproject.toml and uv.lock. Direct dependencies are pinned to the versions in the old Pipfile.lock, and transitive packages that jumped a major version are constrained back. - Pin Python 3.11 in .python-version (was 3.10, unlike CI and Docker) - Dockerfile installs with uv sync --frozen --no-dev into /app/.venv - CI uses astral-sh/setup-uv and uv run - .gcloudignore excludes the .venv symlink - bump2version also updates pyproject.toml and uv.lock - Contributing docs use uv; testing section describes Playwright Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PipfileandPipfile.lockwithpyproject.tomlanduv.lock..python-versionchanges from 3.10 to 3.11, so it matches the old Pipfile, CI and thepython:3.11-slimDocker image.Pipfile.lock(dash 3.2.0, plotly 5.18.0, pandas 2.2.0, numpy 1.26.3, dash-mantine-components 2.2.1, dash-leaflet 1.0.15, and so on).[tool.uv] constraint-dependenciesholds them back to the series the old lock used.Dockerfileinstalls uv 0.13.1, runsuv sync --frozen --no-devinto/app/.venvand starts the app withpython main.py.deploy.ymlandcloudbuild.yamlare unchanged..gcloudignoreexcludes.venv, which uv creates as a symlink. Without itgcloud builds submitcould upload the whole environment.python.ymlusesastral-sh/setup-uv@v10.3.1,uv sync --frozenanduv runfor ruff, Playwright, the app and pytest.pyproject.tomlis 0.10.2..bumpversion.cfgnow also bumps it inpyproject.tomlanduv.lock, souv lock --checkstill passes after a release bump.uv sync,uv run,uv addanduv lock. The testing section ofrun-project-locally.mdnow describes the Playwright tests instead of the removed Cypress tests.Checked
uv run pytest --base-url=http://127.0.0.1:8080 -n 4againstuv run python main.pyon macOS: 29 passed.ruff checkandruff format --checkpass.docker buildx build --platform linux/amd64succeeds. Inside the imageimport mainworks with Python 3.11.17, dash 3.2.0, plotly 5.18.0, pandas 2.2.0, numpy 1.26.3, scipy 1.12.0 and dash-mantine-components 2.2.1.gcloud meta list-files-for-uploadincludespyproject.toml,uv.lockandDockerfile, and nothing from.venv.bump2version patch(run without committing, then reverted) updates all four version files, anduv lock --checkpasses afterwards.Not checked
gcloud builds submitand the Cloud Run deploy.🤖 Generated with Claude Code