Repository navigation
ci: skip the example tests when testing built wheels - #147
GuillaumeLagrange merged 1 commit into
Conversation
tests/examples holds files that other tests copy through pytester. Collected directly, they run pytest-benchmark's own fixture, which reads `node._nodeid`, removed in pytest 9.2 and still read by pytest-benchmark 5.3.0. The wheel tests install the latest pytest, so the v5.0.4 release build failed. The local pytest config already ignores tests/examples. Refs COD-4044 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Low impact] The PR appears safe to merge. SummaryAdds
Reviews (1) · Last reviewed commit: "ci: skip the example tests when testing ..." · Reviewed by Greptile |
Merging this PR will degrade performance by 9.74%3 warnings, 1 note
Performance Changes
Tip Curious why performance improved? Comment Comparing |
tests/examples holds files that other tests copy through pytester. Collected directly, they run pytest-benchmark's own fixture, which reads `node._nodeid`, removed in pytest 9.2 and still read by pytest-benchmark 5.3.0. The wheel tests install the latest pytest, so the v5.0.4 release build failed. The local pytest config already ignores tests/examples. Refs COD-4044 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The wheel tests collect
tests/examplesdirectly, where pytest-benchmark's own fixture readsnode._nodeid, removed in pytest 9.2 and still read by pytest-benchmark 5.3.0. This failed the v5.0.4 release run; skip them in wheel tests, as the local pytest config already does.Refs COD-4044, which stays open until 5.0.4 is on PyPI.