fix(review): stop labelling a base with the run that computed it - #94
Merged
Conversation
A base graph describes one commit and is shared by every pull request that forks there, but its marker carried the pr_number and head_sha of whichever run happened to build it. Reading one made it look owned by a pull request it has nothing to do with. Those two fields are now written only for a warm-start bundle, which genuinely belongs to one pull request. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit cb327b3)
Contributor
CodeBoarding reviewStatus: 0 changed components See the full change in CodeBoarding. graph LR
n_Visual_Rendering_Engine["Visual Rendering Engine"]
n_Structural_Diff_Engine["Structural Diff Engine"]
n_Interaction_Orchestrator["Interaction Orchestrator"]
n_Visual_Rendering_Engine -- "Returns rendering metadata and diagram artifacts" --> n_Interaction_Orchestrator
n_Structural_Diff_Engine -- "Provides annotated diff model for visualization" --> n_Visual_Rendering_Engine
n_Interaction_Orchestrator -- "Triggers structural comparison via CLI" --> n_Structural_Diff_Engine
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed the 1.12.0 release: it was pushed to #93's branch after that PR merged, so it is on the branch but not in
main.The defect
A base graph describes one commit and is shared by every pull request that forks there — the name is
codeboarding-base-<cfg>-<merge_base_sha>, with no pull request in it. But itsmetadata.jsoncarried thepr_numberandhead_shaof whichever run happened to build it:{ "kind": "base", "merge_base_sha": "c9e4c7cf…", "pr_number": "92", "head_sha": "…" }So a shared object looked owned by one pull request it has nothing to do with. Anyone reading it would reasonably conclude bases are per pull request, and either dedupe them wrongly or distrust the sharing.
Those two fields are now written only for a warm-start bundle, which genuinely does belong to one pull request. A base marker is
kind,merge_base_sha,cfg_hash,engine_version.Verification
test_a_base_is_not_labelled_with_the_run_that_computed_itasserts a staged base has nopr_numberorhead_sha, alongside the existing check that a warm-start does. 94 tests pass.Metadata only — no behavioural change to what is published, fetched or reused.
🤖 Generated with Claude Code