Skip to content

fix(review): stop labelling a base with the run that computed it - #94

Merged
Svilen-Stefanov merged 1 commit into
mainfrom
fix/base-marker-not-run-specific
Aug 19, 2026
Merged

fix(review): stop labelling a base with the run that computed it#94
Svilen-Stefanov merged 1 commit into
mainfrom
fix/base-marker-not-run-specific

Conversation

@Svilen-Stefanov

Copy link
Copy Markdown
Contributor

Missed the 1.12.0 release: it was pushed to #93's branch after that PR merged, so it is on the branch but not in main.

The defect

A base graph describes one commit and is shared by every pull request that forks there — the name is codeboarding-base-<cfg>-<merge_base_sha>, with no pull request in it. But its metadata.json carried the pr_number and head_sha of whichever run happened to build it:

{ "kind": "base", "merge_base_sha": "c9e4c7cf…", "pr_number": "92", "head_sha": "" }

So a shared object looked owned by one pull request it has nothing to do with. Anyone reading it would reasonably conclude bases are per pull request, and either dedupe them wrongly or distrust the sharing.

Those two fields are now written only for a warm-start bundle, which genuinely does belong to one pull request. A base marker is kind, merge_base_sha, cfg_hash, engine_version.

Verification

test_a_base_is_not_labelled_with_the_run_that_computed_it asserts a staged base has no pr_number or head_sha, alongside the existing check that a warm-start does. 94 tests pass.

Metadata only — no behavioural change to what is published, fetched or reused.

🤖 Generated with Claude Code

A base graph describes one commit and is shared by every pull request that
forks there, but its marker carried the pr_number and head_sha of whichever
run happened to build it. Reading one made it look owned by a pull request
it has nothing to do with. Those two fields are now written only for a
warm-start bundle, which genuinely belongs to one pull request.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
(cherry picked from commit cb327b3)
@codeboarding-review

codeboarding-review Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

CodeBoarding review

Status: 0 changed components

See the full change in CodeBoarding.

graph LR
    n_Visual_Rendering_Engine["Visual Rendering Engine"]
    n_Structural_Diff_Engine["Structural Diff Engine"]
    n_Interaction_Orchestrator["Interaction Orchestrator"]
    n_Visual_Rendering_Engine -- "Returns rendering metadata and diagram artifacts" --> n_Interaction_Orchestrator
    n_Structural_Diff_Engine -- "Provides annotated diff model for visualization" --> n_Visual_Rendering_Engine
    n_Interaction_Orchestrator -- "Triggers structural comparison via CLI" --> n_Structural_Diff_Engine
    classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
    classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
    classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
Loading

download artifacts · run 32306870781

@Svilen-Stefanov
Svilen-Stefanov merged commit f7630ce into main Aug 19, 2026
3 checks passed
@Svilen-Stefanov
Svilen-Stefanov deleted the fix/base-marker-not-run-specific branch August 19, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant