[rubenvdlinde]

What

Removes private methods, constants and properties that nothing calls from ArchiMateImportService, ArchiMateService, ArchiMateExportService and AangebodenGebruikService. 3,609 lines go, 3 doc lines change, and no caller changes.

How the set was chosen: PHPStan already reported 24 of these private methods and 2 constants as unused (they sat in phpstan-baseline.neon). Removing them left 33 more private methods without a caller, then 5 properties that were only ever written and 2 more unused constants. The removal was repeated until PHPStan on these four files reports nothing unused. Every removed member is private, so no other class or app can reach it, and no test referenced any of them (grep over tests/ for each name). The new files are strict line subsequences of the old ones, apart from one docblock in AangebodenGebruikService that named a removed method.

The baseline loses the 26 entries that matched the removed code.

Kept on purpose: AangebodenGebruikService::checkOrganisationOwnership and getApplicationsOwnedByOrganisation are unused too, but they are ownership checks; whether something should call them is a separate decision.

SIG (gate 122 reader, lizard 1.24.3, five-star profile)

php	development	this PR	4-star	5-star
size >15	84.11%	83.52%	47.1%	23.6%
size >30	62.85%	61.86%	23.1%	11.6%
size >60	36.99%	36.65%	8.3%	4.2%
McCabe >5	52.63%	52.09%	20.2%	10.1%
McCabe >10	20.88%	20.05%	7.3%	3.7%
McCabe >25	3.61%	3.41%	1.1%	0.55%
params >=3	20.58%	19.77%	15.0%	7.5%
params >=5	4.69%	4.40%	3.3%	1.65%
params >=7	0.72%	0.75%	0.9%	0.45%
duplication	11.56%	9.97%	5.6%	2.8%
fan-in >10	11.01%	11.52%	10.0%	5.0%
fan-in >20	11.01%	11.52%	5.6%	2.8%
fan-in >50	9.72%	10.17%	1.9%	0.95%
component independence	29.44%	30.79%	93.7%	93.7%

php unit LOC 44517 -> 42379; module LOC 50466 -> 48252.

No check flips on its own. params >=5 drops from 4.69% to 4.40% (the dead transformSectionObjectsBatch, getObjectsRelatedToUuid and getAllObjectsForSchema took 5 or 6 parameters) and duplication from 11.56% to 9.97%. The fan-in shares rise because the module total shrinks while SettingsService (fan-in 54, 4,906 lines) and Application (fan-in 32) stay the same size; fan-in >10 was missed before and still is.

Verified

• php -l, phpcs (0 errors), phpmd with both rule sets (0 violations), psalm (0 errors) and phpstan (0 errors) on the four files; full phpstan run over lib/ has no new finding.
• Full unit suite once on this head, under pcov with --fail-on-risky (phpunit-unit.xml): 1,506 tests, 20 errors, 0 risky. development gives the identical 20 errors (Doctrine\DBAL\ParameterType missing locally in the Repair migration tests).
• The 27 unit tests of these four classes pass.
• gate 122 ratchet against origin/development: 0 findings (58 inherited); gate 119: 0 files on both refs.
• diff-check: gates, php -l, phpcs and phpstan PASS with 0 new. Its phpunit step exits 255 because it runs phpunit.xml, whose bootstrap needs a Nextcloud server tree; that happens on development too. The same filter under phpunit-unit.xml passes (27 tests).
• No golden or mutants: nothing that runs changed. The safety argument is that every removed member was private and had no caller left, checked by PHPStan after each round.
• development (with refactor(store): split the related-data fetch and make the stackiq plugin measurable #1370, refactor(cmdb-import): look error texts up in a table #1371, refactor(store): drive the focused schema selections from key tables #1372 and ci(quality): block on the SIG unit ratchet and commit the SIG score floor #1373) merged in before the push; gate 123 (sig-floor) on the merged head: PASS, 29 floored checks held.

AI disclosure: prepared with Claude Code (claude-opus-5-5) and reviewed by the lane before opening.

[github-actions]

Quality Report — ConductionNL/stackiq @ 546c1e6

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue-demi		✅
test-l10n		✅
format		❌
check-schema-l10n		❌
check-l10n-js		✅
composer			❌	✅ 127/127
npm			❌	✅ 807/807
app:check-code	⏭️
info.xml	✅
REUSE	❌
lockfile sync		✅
PHPUnit					✅ 1486/1486 · 20 skipped
Newman					⏭️
Playwright					⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates					❌

---

Quality workflow — 2026-11-02 21:43 UTC

Download the full PDF report from the workflow artifacts.