Skip to content

fix(droid-control): support tctl on Windows - #44

Merged
factory-ain3sh merged 1 commit into
masterfrom
david/fix-tctl-windows
Aug 28, 2026
Merged

fix(droid-control): support tctl on Windows#44
factory-ain3sh merged 1 commit into
masterfrom
david/fix-tctl-windows

Conversation

@factory-davidgu

Copy link
Copy Markdown
Contributor

Description

On Windows, tctl passed its generated .sh runner directly to Tuistory. Windows followed the shell script file association and opened Git Bash/Mintty outside Tuistory's PTY, leaving Droid Control with blank output and orphaned terminal windows.

Windows MSYS environments now launch the generated runner explicitly through bash.exe. Both executable paths use DOS short paths because Tuistory's Windows command parser does not preserve quoted executable paths containing spaces. Linux and macOS behavior is unchanged.

Potential Risk & Impact

  • The new path only runs under MINGW, MSYS, and Cygwin.
  • Windows execution now requires cygpath, which ships with the Git Bash environment already required to run tctl.
  • Tuistory recording uses the same explicit Bash runner path.

How Has This Been Tested?

  • bash -n plugins/droid-control/bin/tctl
  • Windows non-interactive smoke test through the cloned tctl: captured TCTL_ECHO_OK
  • Windows interactive smoke test through the cloned tctl: typed a PowerShell command and captured TCTL_INTERACTIVE_OK
  • Confirmed the fixed wrapper no longer leaves test-related Git Bash, Mintty, shell, or Bun processes running

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@factory-ain3sh
factory-ain3sh marked this pull request as ready for review August 28, 2026 22:13

@factory-ain3sh factory-ain3sh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@factory-ain3sh
factory-ain3sh merged commit 7358337 into master Aug 28, 2026
1 check passed
@factory-ain3sh
factory-ain3sh deleted the david/fix-tctl-windows branch August 28, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants