fix(droid-control): support tctl on Windows - #44
Merged
Conversation
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
factory-ain3sh
marked this pull request as ready for review
August 28, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Windows,
tctlpassed its generated.shrunner directly to Tuistory. Windows followed the shell script file association and opened Git Bash/Mintty outside Tuistory's PTY, leaving Droid Control with blank output and orphaned terminal windows.Windows MSYS environments now launch the generated runner explicitly through
bash.exe. Both executable paths use DOS short paths because Tuistory's Windows command parser does not preserve quoted executable paths containing spaces. Linux and macOS behavior is unchanged.Potential Risk & Impact
cygpath, which ships with the Git Bash environment already required to runtctl.How Has This Been Tested?
bash -n plugins/droid-control/bin/tctltctl: capturedTCTL_ECHO_OKtctl: typed a PowerShell command and capturedTCTL_INTERACTIVE_OK