Skip to content

fix(droid-control): support tctl on Windows #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
factory-ain3sh merged 1 commit into from
Aug 28, 2026
+14 −0
Merged

fix(droid-control): support tctl on Windows #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions plugins/droid-control/bin/tctl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,20 @@ launch_tuistory() {
cleanup_tuistory_asciinema "$session" "$record_path"
launch_cmd="$(write_tuistory_recording_runner "$session" "$record_path")"
fi
# On Windows, passing a .sh file directly makes CreateProcess follow the
# file association and open Git Bash/Mintty outside Tuistory's PTY. Launch
# the runner through bash.exe instead. Tuistory's Windows command parser
# does not preserve quoted executable paths, so use DOS short paths to keep
# both argv entries whitespace-free.
case "$(uname -s)" in
MINGW*|MSYS*|CYGWIN*)
require_cmd cygpath
local bash_win runner_win
bash_win="$(cygpath -w -s "$(command -v bash)")"
runner_win="$(cygpath -w -s "$launch_cmd")"
launch_cmd="$bash_win $runner_win"
;;
esac
local args=(launch "$launch_cmd" -s "$session" --cols "$cols" --rows "$rows")
tuistory "${args[@]}"
}
Expand Down
Loading