Skip to content

fix(Mobile): Fix the feature drawer layout on phones - #8994

Draft
talissoncosta wants to merge 7 commits into
mainfrom
fix/mobile-modal-content-height
Draft

talissoncosta wants to merge 7 commits into
mainfrom
fix/mobile-modal-content-height

Conversation

@talissoncosta

@talissoncosta talissoncosta commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

A customer couldn't edit a segment override from their phone: the feature drawer stopped drawing its background halfway down and the rule fields were squeezed.

  • Drawers grow with their content on phones (min-height instead of height: 100vh). Dialogs stay cards sized to their content instead of filling the screen.
  • Feature drawer tabs get the desktop spacing on phones.
  • Segment rule fields stack at full width; AND / AND NOT buttons are full width and evenly spaced.
  • The feature drawer title shows just the flag name on phones, with the copy button beside it.
  • The environment summary shows two metrics per row on phones, one row from 768px up.

First of a stack: #8995 (Popover sheet), then #8996 (DropdownMenu).

How did you test this code?

At 393px and 1440px, light and dark:

  • Features → a flag → Segment Overrides → Create Feature-Specific Segment: background reaches the bottom, rule fields stack, buttons full width.
  • Remove feature confirm: a card, not full screen.
  • Summary accordion: 2 per row on phones, 4 on one row on desktop.
  • Other centred modals (Create Project, payment) on a phone.

…le on phones

- Drawers grow with their content (min-height), so the lower half no longer
  renders without a background over the page. Dialogs stay content-sized cards.
- Feature drawer tabs get the desktop spacing on phones.
- Segment rule fields stack at full width; AND / AND NOT buttons are
  full width and evenly spaced, with the click on the button itself.
- The feature drawer title shows just the flag name on phones, with the
  copy button beside it.
- The environment summary shows two metrics per row on phones.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Nov 17, 2026 3:27pm UTC
flagsmith-frontend-staging Ready Ready Preview Nov 17, 2026 3:27pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 17, 2026 3:27pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • Resume reviews
  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The changes update responsive layouts in the feature modal, segment rule editor and metrics grid. The feature modal header truncates feature names and hides selected content on smaller screens. Side-modal styling is scoped to side modals at smaller viewports. Segment rule controls use responsive layouts, and each addition button handles its own click. The metrics grid uses CSS columns instead of an inline column count.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · up to c34e2

This PR adjusts mobile layouts for drawers, segment rule fields and the metrics summary. No concrete defects were found, so the merge risk is minimal.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0958d433-10f7-4a40-acae-43f7d6086177
Commits

Reviewing files that changed from the base of the PR and between 8b754f6 and c34e2b3.

Files selected for processing: 2

  • frontend/web/styles/components/_metrics.scss
  • frontend/web/styles/project/_modals.scss
Files with no reviewable changes: 1

  • frontend/web/styles/components/_metrics.scss

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Nov 17, 2026
@github-actions github-actions Bot added the fix label Nov 17, 2026
@talissoncosta
talissoncosta marked this pull request as ready for review November 17, 2026 14:17
@talissoncosta
talissoncosta requested a review from a team as a code owner November 17, 2026 14:17
@talissoncosta
talissoncosta requested review from kyle-ssg and removed request for a team November 17, 2026 14:17
@github-actions github-actions Bot removed the fix label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-8994 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8994 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api-test:pr-8994 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-8994 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8994 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-e2e:pr-8994 Finished ✅ Skipped

@github-actions github-actions Bot added the fix label Nov 17, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The feature drawer's tab spacing matches desktop, so it no longer needs a
breakpoint, and .p-0 is already !important.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@github-actions github-actions Bot added fix and removed fix labels Nov 17, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 555022f1-296e-402c-8e82-6b9142017d2e
Commits

Reviewing files that changed from the base of the PR and between 05b073c and 1629fc7.

Files selected for processing: 6

  • frontend/web/components/feature-summary/FeatureRow.tsx
  • frontend/web/components/metrics/EnvironmentMetricsList.tsx
  • frontend/web/components/modals/CreateSegment.tsx
  • frontend/web/components/segments/Rule/components/RuleConditionRow.tsx
  • frontend/web/styles/components/_metrics.scss
  • frontend/web/styles/project/_modals.scss

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Bootstrap caps .modal-dialog at --bs-modal-width from 544px, so below the
md breakpoint the drawer turned into a narrow card.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot removed the fix label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #23352 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  58.4 seconds
commit  c34e2b3
info  🔄 Run: #23352 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23352 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  37.1 seconds
commit  c34e2b3
info  🔄 Run: #23352 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23352 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  22 passed
skipped  1 skipped

Details

stats  23 tests across 14 suites
duration  1 minute, 18 seconds
commit  c34e2b3
info  🔄 Run: #23352 (attempt 1)

Skipped tests

firefox › tests/onboarding-tests.pw.ts › Onboarding › New user connects via the single-page onboarding flow @oss

✅ oss · depot-ubuntu-latest-arm-16 — run #23352 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  20.9 seconds
commit  c34e2b3
info  🔄 Run: #23352 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #23345 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  55.6 seconds
commit  8b754f6
info  🔄 Run: #23345 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23345 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  37.4 seconds
commit  8b754f6
info  🔄 Run: #23345 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23345 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.9 seconds
commit  8b754f6
info  🔄 Run: #23345 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23345 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  30.7 seconds
commit  8b754f6
info  🔄 Run: #23345 (attempt 1)

❌ private-cloud · depot-ubuntu-latest-arm-16 — run #23343 (attempt 2)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

failed  12 failed

Details

stats  12 tests across 5 suites
duration  25.4 seconds
commit  15b53f9
info  📦 Artifacts: View test results and HTML report
🔄 Run: #23343 (attempt 2)

Failed tests

firefox › tests/change-request-page-test.pw.ts › Change Request Page › A change request can be deleted from its page @enterprise
firefox › tests/change-request-page-test.pw.ts › Change Request Page › Assignees can be added and removed, and stay after a reload @enterprise
firefox › tests/change-request-page-test.pw.ts › Change Request Page › A change request for a deleted feature says so @enterprise
firefox › tests/change-request-page-test.pw.ts › Change Request Page › Opening another change request shows its own changes @enterprise
firefox › tests/change-request-page-test.pw.ts › Change Request Page › A change request in a versioned environment can be approved and published @enterprise
firefox › tests/change-request-test.pw.ts › Change Request Tests › Change requests can be created, approved, and published with four-eyes approval @enterprise
firefox › tests/change-request-test.pw.ts › Change Request Tests › A segment override change request in a versioned environment opens on its Segment Overrides diff @enterprise
firefox › tests/change-request-test.pw.ts › Change Request Tests › An open change request can be edited from its page @enterprise
firefox › tests/change-request-test.pw.ts › Change Request Tests › A change request scheduled for later shows as a scheduled change @enterprise
firefox › tests/roles-test.pw.ts › Roles Tests › Roles can be created with project and environment permissions @enterprise
firefox › tests/segment-test.pw.ts › Segment test 5 - Audit log shows segment rule changes @enterprise
firefox › tests/sso-test.pw.ts › SCIM Tests › SCIM configuration can be created, regenerated, and deleted @enterprise

❌ private-cloud · depot-ubuntu-latest-16 — run #23343 (attempt 2)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  14 failed

Details

stats  14 tests across 7 suites
duration  37.7 seconds
commit  15b53f9
info  📦 Artifacts: View test results and HTML report
🔄 Run: #23343 (attempt 2)

Failed tests

firefox › tests/change-request-page-test.pw.ts › Change Request Page › A change request can be deleted from its page @enterprise
firefox › tests/change-request-page-test.pw.ts › Change Request Page › Assignees can be added and removed, and stay after a reload @enterprise
firefox › tests/change-request-page-test.pw.ts › Change Request Page › A change request for a deleted feature says so @enterprise
firefox › tests/change-request-page-test.pw.ts › Change Request Page › Opening another change request shows its own changes @enterprise
firefox › tests/change-request-page-test.pw.ts › Change Request Page › A change request in a versioned environment can be approved and published @enterprise
firefox › tests/change-request-test.pw.ts › Change Request Tests › Change requests can be created, approved, and published with four-eyes approval @enterprise
firefox › tests/change-request-test.pw.ts › Change Request Tests › A segment override change request in a versioned environment opens on its Segment Overrides diff @enterprise
firefox › tests/change-request-test.pw.ts › Change Request Tests › An open change request can be edited from its page @enterprise
firefox › tests/change-request-test.pw.ts › Change Request Tests › A change request scheduled for later shows as a scheduled change @enterprise
firefox › tests/environment-permission-test.pw.ts › Environment Permission Tests › Environment-level permissions control access to features, identities, and segments @enterprise
firefox › tests/project-permission-test.pw.ts › Project Permission Tests › Project-level permissions control access to features, environments, audit logs, and segments @enterprise
firefox › tests/roles-test.pw.ts › Roles Tests › Roles can be created with project and environment permissions @enterprise
firefox › tests/segment-test.pw.ts › Segment test 5 - Audit log shows segment rule changes @enterprise
firefox › tests/sso-test.pw.ts › SCIM Tests › SCIM configuration can be created, regenerated, and deleted @enterprise

✅ oss · depot-ubuntu-latest-arm-16 — run #23343 (attempt 2)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  36.4 seconds
commit  15b53f9
info  🔄 Run: #23343 (attempt 2)

✅ oss · depot-ubuntu-latest-16 — run #23343 (attempt 2)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  31.7 seconds
commit  15b53f9
info  🔄 Run: #23343 (attempt 2)

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Auto-approval blocked by 3 unresolved issues from previous reviews.

Turn on auto-fix | Re-trigger cubic

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Visual Regression

24 screenshots compared. See report for details.
View full report

…ide their row

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Auto-approval blocked by 2 unresolved issues from previous reviews.

Turn on auto-fix | Re-trigger cubic

…ar shows

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Nov 17, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Mobile usability fixes for the feature drawer title, segment rule editor, metrics grid, and modal sizing; all changes are bounded CSS/JSX-only adjustments with no contract/policy impact. Dismissed findings are out of scope or match intended layout.

Turn on auto-fix | Re-trigger cubic

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Mobile usability fixes for feature drawer titles, segment rules, metrics grid, and modal/drawer sizing. CSS/JSX-only changes with no contract or operational impact; dismissed findings are out of scope or match intended layout.

Turn on auto-fix | Re-trigger cubic

@talissoncosta talissoncosta changed the title fix(Mobile): Keep drawers, segment rules and the feature summary usable on phones fix(Mobile): Fix the create feature layout on phones Nov 17, 2026
@talissoncosta talissoncosta changed the title fix(Mobile): Fix the create feature layout on phones fix(Mobile): Fix the feature drawer layout on phones Nov 17, 2026
@talissoncosta
talissoncosta marked this pull request as draft November 17, 2026 15:36

This branch was successfully deployed

2 active deployments
Preview – flagsmith-frontend-staging — c34e2b3c Deployed Nov 17, 2026 by vercel[bot]
Preview – flagsmith-frontend-preview — c34e2b3c Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant