Repository navigation
feat(Popover): Open as a bottom sheet on phones - #8995
talissoncosta wants to merge 7 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
ee16aff to
9f9f33d
Compare
9f9f33d to
4fcad7a
Compare
Docker builds report
|
Below 768px a Popover's content opens in a bottom sheet (overlay, scroll
lock, focus trap, Escape and outside tap to close) instead of an anchored
panel. The trigger announces it with aria-haspopup="dialog" and
aria-expanded. useBreakpoint('isPhone') matches Bootstrap's md breakpoint.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4fcad7a to
85c4880
Compare
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23358 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-16 — run #23358 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-16 — run #23358 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #23358 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ private-cloud · depot-ubuntu-latest-16 — run #23354 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23354 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #23354 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ private-cloud · depot-ubuntu-latest-16 — run #23351 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #23354 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23351 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #23351 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #23351 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
|
… modes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Visual Regression24 screenshots compared. See report for details. |
…t jump Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs/if required so people know about the feature.Changes
Stacked on #8994.
Below 768px,
Popovercontent opens in a bottom sheet instead of an anchored panel: overlay, scroll lock, focus trap, Escape and outside tap to close. The trigger getsaria-haspopup="dialog"andaria-expanded.BottomSheetis internal toPopoverfor now; it moves tobase/when something else needs it.useBreakpoint('isPhone')matches Bootstrap's md breakpoint, so JS and SCSS switch at the same width.Nothing in the app uses
Popoveryet; the next PR (DropdownMenu) is its first consumer.How did you test this code?
Popover / MobileSheetopens as a sheet;Defaultstays anchored.matchesBreakpoint.aria-expandedtoggles.