Skip to content

feat(Popover): Open as a bottom sheet on phones - #8995

Draft
talissoncosta wants to merge 7 commits into
fix/mobile-modal-content-heightfrom
feat/popover-bottom-sheet
Draft

talissoncosta wants to merge 7 commits into
fix/mobile-modal-content-heightfrom
feat/popover-bottom-sheet

Conversation

@talissoncosta

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Stacked on #8994.

Below 768px, Popover content opens in a bottom sheet instead of an anchored panel: overlay, scroll lock, focus trap, Escape and outside tap to close. The trigger gets aria-haspopup="dialog" and aria-expanded.

  • BottomSheet is internal to Popover for now; it moves to base/ when something else needs it.
  • useBreakpoint('isPhone') matches Bootstrap's md breakpoint, so JS and SCSS switch at the same width.

Nothing in the app uses Popover yet; the next PR (DropdownMenu) is its first consumer.

How did you test this code?

  • Storybook: Popover / MobileSheet opens as a sheet; Default stays anchored.
  • Unit tests for matchesBreakpoint.
  • In the app via the next PR: tabs and nav menus open as a sheet at 393px, Escape closes, trigger aria-expanded toggles.

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Nov 18, 2026 1:12pm UTC
flagsmith-frontend-staging Ready Ready Preview Nov 18, 2026 1:12pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 18, 2026 1:12pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Nov 17, 2026
@talissoncosta
talissoncosta force-pushed the feat/popover-bottom-sheet branch from ee16aff to 9f9f33d Compare November 17, 2026 14:56
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Nov 17, 2026
@talissoncosta
talissoncosta force-pushed the feat/popover-bottom-sheet branch from 9f9f33d to 4fcad7a Compare November 17, 2026 15:23
@github-actions github-actions Bot removed the feature New feature or request label Nov 17, 2026
@github-actions github-actions Bot added the feature New feature or request label Nov 17, 2026
@talissoncosta
talissoncosta marked this pull request as ready for review November 17, 2026 15:24
@talissoncosta
talissoncosta requested a review from a team as a code owner November 17, 2026 15:24
@talissoncosta
talissoncosta requested review from kyle-ssg and removed request for a team November 17, 2026 15:24
@github-actions github-actions Bot removed the feature New feature or request label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-8995 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8995 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8995 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8995 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8995 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8995 Finished ✅ Results ✅

@github-actions github-actions Bot added the feature New feature or request label Nov 17, 2026
talissoncosta and others added 4 commits November 17, 2026 12:26
Below 768px a Popover's content opens in a bottom sheet (overlay, scroll
lock, focus trap, Escape and outside tap to close) instead of an anchored
panel. The trigger announces it with aria-haspopup="dialog" and
aria-expanded. useBreakpoint('isPhone') matches Bootstrap's md breakpoint.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23358 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  36.4 seconds
commit  e5f2156
info  🔄 Run: #23358 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-16 — run #23358 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  6 passed

Details

stats  6 tests across 6 suites
duration  33.6 seconds
commit  e5f2156
info  🔄 Run: #23358 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23358 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.1 seconds
commit  e5f2156
info  🔄 Run: #23358 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23358 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  35.3 seconds
commit  e5f2156
info  🔄 Run: #23358 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #23354 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  34.6 seconds
commit  85c4880
info  🔄 Run: #23354 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23354 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  37 seconds
commit  85c4880
info  🔄 Run: #23354 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23354 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.4 seconds
commit  85c4880
info  🔄 Run: #23354 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #23351 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  37 seconds
commit  4fcad7a
info  🔄 Run: #23351 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23354 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  35.1 seconds
commit  85c4880
info  🔄 Run: #23354 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23351 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  36.5 seconds
commit  4fcad7a
info  🔄 Run: #23351 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23351 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.7 seconds
commit  4fcad7a
info  🔄 Run: #23351 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23351 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34 seconds
commit  4fcad7a
info  🔄 Run: #23351 (attempt 1)

… modes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Visual Regression

24 screenshots compared. See report for details.
View full report

…t jump

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

2 active deployments
Preview – flagsmith-frontend-staging — fde57c43 Deployed Nov 18, 2026 by vercel[bot]
Preview – flagsmith-frontend-preview — fde57c43 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant