Skip to content

feat(DropdownMenu): One menu component for actions, tabs and nav overflow - #8996

Draft
talissoncosta wants to merge 4 commits into
feat/popover-bottom-sheetfrom
feat/dropdown-menu
Draft

talissoncosta wants to merge 4 commits into
feat/popover-bottom-sheetfrom
feat/dropdown-menu

Conversation

@talissoncosta

@talissoncosta talissoncosta commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Stacked on #8995.

DropdownMenu takes any element as its trigger and DropdownMenuItem children (icon, current with a tick, destructive, disabled). Built on Popover, so menus open as a bottom sheet on phones. Items close the menu after onSelect.

Consumers:

  • Replaces the legacy items-based DropdownMenu in StaleSection, ExperimentActionDropdown, ReleasePipelinesList, IntegrationList (deleted).
  • Tabs overflow: "More tabs" on desktop. On phones the tabs scroll sideways instead, with the edge that has more tabs faded and the active tab kept in view (useTabScroller).
  • OverflowNav (project, organisation and environment navs) instead of InlineModal, with a required label so each button has its own name.
  • TabLabel renders a tab's label and unsaved-changes dot for both the tab and the menu.
  • E2E helpers find these menus by role and name instead of data-test.

How did you test this code?

At 393px and 1440px:

  • Feature drawer tabs on a phone: all tabs scroll sideways, the cut-off edge fades, picking one centres it. Also from a ?tab= link.
  • Project nav overflow: popover on desktop, sheet on a phone; picking a link navigates and closes.
  • Release pipelines actions: Edit disabled when published, Remove in red, Escape closes.
  • Integrations actions (Grafana, Jira).
  • Experiments actions (needs a project with a data warehouse).
  • Stale flags actions on Lifecycle (needs stale flags).
  • Configured integration row menu (Edit / Delete).
  • Desktop tabs overflow (the feature drawer fits all tabs at desktop widths).

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Nov 18, 2026 1:26pm UTC
flagsmith-frontend-staging Ready Ready Preview Nov 18, 2026 1:26pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 18, 2026 1:26pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Nov 17, 2026
@talissoncosta
talissoncosta force-pushed the feat/popover-bottom-sheet branch from ee16aff to 9f9f33d Compare November 17, 2026 14:56
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Nov 17, 2026
@talissoncosta
talissoncosta force-pushed the feat/popover-bottom-sheet branch from 9f9f33d to 4fcad7a Compare November 17, 2026 15:23
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Nov 17, 2026
@talissoncosta
talissoncosta force-pushed the feat/popover-bottom-sheet branch from 4fcad7a to 85c4880 Compare November 17, 2026 15:27
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Nov 17, 2026
talissoncosta and others added 2 commits November 18, 2026 10:07
…flow

DropdownMenu takes any element as its trigger and DropdownMenuItem
children (icon, current with a tick, destructive, disabled). It is built
on Popover, so menus open as a bottom sheet on phones, and items close the
menu after onSelect.

- Replaces the legacy items-based DropdownMenu in StaleSection,
  ExperimentActionDropdown, ReleasePipelinesList and IntegrationList.
- Tabs overflow uses it: a "More tabs" button on desktop, and on phones
  the current section as a title that opens the full list.
- OverflowNav uses it instead of InlineModal, with a required label so
  each nav's button has its own name.
- TabLabel holds the tab label and unsaved-changes dot for both places.
- E2E helpers find these menus by role and name instead of data-test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…king on touch screens

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a menu

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

2 active deployments
Preview – flagsmith-frontend-preview — ae22fb4e Deployed Nov 18, 2026 by vercel[bot]
Preview – flagsmith-frontend-staging — ae22fb4e Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant