Repository navigation
feat(DropdownMenu): One menu component for actions, tabs and nav overflow - #8996
Draft
talissoncosta wants to merge 4 commits into
Draft
talissoncosta wants to merge 4 commits into
talissoncosta wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 17, 2026
talissoncosta
force-pushed
the
feat/popover-bottom-sheet
branch
from
November 17, 2026 14:56
ee16aff to
9f9f33d
Compare
talissoncosta
force-pushed
the
feat/dropdown-menu
branch
from
November 17, 2026 14:56
3b8a120 to
270b264
Compare
talissoncosta
force-pushed
the
feat/dropdown-menu
branch
from
November 17, 2026 15:23
270b264 to
c7a8e20
Compare
talissoncosta
force-pushed
the
feat/popover-bottom-sheet
branch
from
November 17, 2026 15:23
9f9f33d to
4fcad7a
Compare
talissoncosta
force-pushed
the
feat/popover-bottom-sheet
branch
from
November 17, 2026 15:27
4fcad7a to
85c4880
Compare
talissoncosta
force-pushed
the
feat/dropdown-menu
branch
from
November 17, 2026 15:27
c7a8e20 to
40e2108
Compare
talissoncosta
force-pushed
the
feat/dropdown-menu
branch
from
November 17, 2026 15:33
40e2108 to
d0b68fc
Compare
…flow DropdownMenu takes any element as its trigger and DropdownMenuItem children (icon, current with a tick, destructive, disabled). It is built on Popover, so menus open as a bottom sheet on phones, and items close the menu after onSelect. - Replaces the legacy items-based DropdownMenu in StaleSection, ExperimentActionDropdown, ReleasePipelinesList and IntegrationList. - Tabs overflow uses it: a "More tabs" button on desktop, and on phones the current section as a title that opens the full list. - OverflowNav uses it instead of InlineModal, with a required label so each nav's button has its own name. - TabLabel holds the tab label and unsaved-changes dot for both places. - E2E helpers find these menus by role and name instead of data-test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
talissoncosta
force-pushed
the
feat/dropdown-menu
branch
from
November 18, 2026 13:11
d0b68fc to
0c152c2
Compare
…king on touch screens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a menu Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Stacked on #8995.
DropdownMenutakes any element as its trigger andDropdownMenuItemchildren (icon,currentwith a tick,destructive,disabled). Built onPopover, so menus open as a bottom sheet on phones. Items close the menu afteronSelect.Consumers:
DropdownMenuinStaleSection,ExperimentActionDropdown,ReleasePipelinesList,IntegrationList(deleted).Tabsoverflow: "More tabs" on desktop. On phones the tabs scroll sideways instead, with the edge that has more tabs faded and the active tab kept in view (useTabScroller).OverflowNav(project, organisation and environment navs) instead ofInlineModal, with a requiredlabelso each button has its own name.TabLabelrenders a tab's label and unsaved-changes dot for both the tab and the menu.data-test.How did you test this code?
At 393px and 1440px:
?tab=link.