Skip to content

fix(Tokens): Make border colours apply and follow dark mode - #9003

Merged
talissoncosta merged 3 commits into
mainfrom
fix/border-token-colours
Nov 17, 2026
Merged

talissoncosta merged 3 commits into
mainfrom
fix/border-token-colours

Conversation

@talissoncosta

@talissoncosta talissoncosta commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

border border-warning draws the default colour, because Bootstrap's .border (with !important) beats our token colour classes.

  • Bootstrap's border-color utility generates .border-* with the token colours, so they come after .border and win.
  • --bs-border-color is set on body instead of :root, so it follows dark mode.

Visible changes: token border colours now apply (MV "Currently served" box, permission chips, segment rule warning inputs), and plain .borders use the dark token in dark mode. The "Currently served" box, which only showed its colours with this fix, is simplified: one gold outline, the value at full strength (new readOnly on ValueEditor), and the stale warning uses the DS Banner.

How did you test this code?

Checked the computed border colours in light and dark.

Check in both themes:

  • Multivariate override serving a value that matches no variation, "Currently served" box (mv/VariationOptions.tsx): DS warning banner, gold outline, value at full strength
  • Permission summary chips (PermissionsSummaryList.tsx): border turns green/gold but text stays purple, fixed in fix(Permissions): Colour the permission summary chips by access level #9004
  • Segment rule input with a warning (segments/Rule/components/RuleConditionValueInput.tsx, TextAreaModal.tsx): warning border, also while focused
  • Organisation → Usage: cards, billing strip, breakdown rows (pages/usage/components/*)
  • Usage chart tooltip divider (charts/ChartTooltip.tsx)
  • Organisation → Usage → SDK labels chart (organisation-settings/usage/components/SingleSDKLabelsChart.tsx)
  • Environment settings → Warehouse tab (pages/environment-settings/tabs/warehouse-tab/WarehouseConnectionCard.tsx)

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Nov 17, 2026 8:14pm UTC
flagsmith-frontend-staging Ready Ready Preview Nov 17, 2026 8:14pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 17, 2026 8:14pm UTC

Request Review

@talissoncosta talissoncosta self-assigned this Nov 17, 2026
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The generator no longer creates border utility classes, and the explicit .border-* classes were removed. Bootstrap now maps eight border-colour utility values to design-system tokens. Its default --bs-border-color declaration is scoped to body instead of :root. The diverged variant’s “Currently served” section no longer uses a warning background or border. ValueEditor now supports a readOnly prop, and FeatureValueTab uses Banner for the stale-variation warning.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: Minimal · up to 79621

The change makes token border colours apply correctly with Bootstrap's .border and highlights the currently served value. No merge-blocking risk was found; the "Currently served" box visual check is still marked unchecked by the author.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 11128db8-288f-4bd7-975f-36905816ab41
Commits

Reviewing files that changed from the base of the PR and between c20796e and 79621ce.

Files selected for processing: 3

  • frontend/web/components/ValueEditor/ValueEditor.tsx
  • frontend/web/components/modals/create-feature/tabs/FeatureValueTab.tsx
  • frontend/web/components/mv/VariationOptions.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review.

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard fix labels Nov 17, 2026
@talissoncosta
talissoncosta force-pushed the fix/border-token-colours branch from 521e2e6 to a7ae4fe Compare November 17, 2026 19:29
@talissoncosta talissoncosta changed the title fix(Styles): Make token border colours beat Bootstrap's .border fix(Styles): Make token border colours work with Bootstrap's .border Nov 17, 2026
@github-actions github-actions Bot added fix and removed fix labels Nov 17, 2026
@github-actions github-actions Bot added fix and removed fix labels Nov 17, 2026
@talissoncosta
talissoncosta marked this pull request as ready for review November 17, 2026 19:32
@talissoncosta
talissoncosta requested a review from a team as a code owner November 17, 2026 19:32
@talissoncosta
talissoncosta requested review from kyle-ssg and removed request for a team November 17, 2026 19:32
@github-actions github-actions Bot added fix and removed fix labels Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-9003 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-9003 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-9003 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-9003 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-9003 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-9003 Finished ✅ Results ✅

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread frontend/scripts/generate-tokens.mjs Resolved

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 750c1133-69e1-49dc-b26a-556be1a5fa4d
Commits

Reviewing files that changed from the base of the PR and between b5fc451 and ae5cf9d.

Files selected for processing: 3

  • frontend/scripts/generate-tokens.mjs
  • frontend/web/styles/3rdParty/_bootstrap.scss
  • frontend/web/styles/_token-utilities.scss

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #23386 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 3 seconds
commit  79621ce
info  🔄 Run: #23386 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23386 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  35.7 seconds
commit  79621ce
info  🔄 Run: #23386 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23386 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.1 seconds
commit  79621ce
info  🔄 Run: #23386 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23386 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  36.6 seconds
commit  79621ce
info  🔄 Run: #23386 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #23385 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 5 seconds
commit  c20796e
info  🔄 Run: #23385 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23385 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 10 seconds
commit  c20796e
info  🔄 Run: #23385 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23385 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.5 seconds
commit  c20796e
info  🔄 Run: #23385 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23385 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.6 seconds
commit  c20796e
info  🔄 Run: #23385 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #23382 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  3.8 seconds
commit  6c31595
info  🔄 Run: #23382 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23382 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.8 seconds
commit  6c31595
info  🔄 Run: #23382 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23382 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  22 passed
skipped  1 skipped

Details

stats  23 tests across 14 suites
duration  1 minute, 15 seconds
commit  6c31595
info  🔄 Run: #23382 (attempt 1)

Skipped tests

firefox › tests/onboarding-tests.pw.ts › Onboarding › New user connects via the single-page onboarding flow @oss

✅ oss · depot-ubuntu-latest-arm-16 — run #23382 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  35.6 seconds
commit  6c31595
info  🔄 Run: #23382 (attempt 1)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Visual Regression

25 screenshots compared. See report for details.
View full report

cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Nov 17, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 reviewed files. 1 file intentionally excluded from review.

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Fixes token border colors to override Bootstrap's .border by moving them into Bootstrap's border-color utilities and setting the default border variable on body for dark mode. Bounded styling fix; dismissed finding addressed by applying color on the element.

Turn on auto-fix | Re-trigger cubic

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Nov 17, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Bounded styling fix: token border colors now generate as Bootstrap border-color utilities so border border-warning wins, with the default border variable on body for dark mode. The dismissed inheritance finding is resolved since border-color applies to the element and does not inherit.

Turn on auto-fix | Re-trigger cubic

@github-actions github-actions Bot added fix and removed fix labels Nov 17, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 3 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Bounded styling fix: token border colours now generate as Bootstrap border-color utilities so border border-warning wins, plain .borders use the dark token via a body variable, and the "Currently served" box is simplified with a readOnly ValueEditor.

Turn on auto-fix | Re-trigger cubic

@talissoncosta talissoncosta changed the title fix(Styles): Make token border colours work with Bootstrap's .border fix(Styles): Make border colours apply and follow dark mode Nov 17, 2026
@talissoncosta talissoncosta changed the title fix(Styles): Make border colours apply and follow dark mode fix(Tokens): Make border colours apply and follow dark mode Nov 17, 2026
@talissoncosta
talissoncosta merged commit a117a65 into main Nov 17, 2026
32 checks passed
@talissoncosta
talissoncosta deleted the fix/border-token-colours branch November 17, 2026 20:51

This branch was successfully deployed

2 active deployments
Preview – flagsmith-frontend-staging — 79621ce7 Deployed Nov 17, 2026 by vercel[bot]
Preview – flagsmith-frontend-preview — 79621ce7 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant