You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(Tokens): Make border colours apply and follow dark mode - #9003
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.
Changes
border border-warning draws the default colour, because Bootstrap's .border (with !important) beats our token colour classes.
Bootstrap's border-color utility generates .border-* with the token colours, so they come after .border and win.
--bs-border-color is set on body instead of :root, so it follows dark mode.
Visible changes: token border colours now apply (MV "Currently served" box, permission chips, segment rule warning inputs), and plain .borders use the dark token in dark mode. The "Currently served" box, which only showed its colours with this fix, is simplified: one gold outline, the value at full strength (new readOnly on ValueEditor), and the stale warning uses the DS Banner.
How did you test this code?
Checked the computed border colours in light and dark.
Check in both themes:
Multivariate override serving a value that matches no variation, "Currently served" box (mv/VariationOptions.tsx): DS warning banner, gold outline, value at full strength
No actionable comments were generated in the recent review.
Walkthrough
The generator no longer creates border utility classes, and the explicit .border-* classes were removed. Bootstrap now maps eight border-colour utility values to design-system tokens. Its default --bs-border-color declaration is scoped to body instead of :root. The diverged variant’s “Currently served” section no longer uses a warning background or border. ValueEditor now supports a readOnly prop, and FeatureValueTab uses Banner for the stale-variation warning.
The change makes token border colours apply correctly with Bootstrap's .border and highlights the currently served value. No merge-blocking risk was found; the "Currently served" box visual check is still marked unchecked by the author.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review.
talissoncosta
changed the title
fix(Styles): Make token border colours beat Bootstrap's .border
fix(Styles): Make token border colours work with Bootstrap's .border
Nov 17, 2026
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 750c1133-69e1-49dc-b26a-556be1a5fa4d
Commits
Reviewing files that changed from the base of the PR and between b5fc451 and ae5cf9d.
Files selected for processing: 3
frontend/scripts/generate-tokens.mjs
frontend/web/styles/3rdParty/_bootstrap.scss
frontend/web/styles/_token-utilities.scss
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
0 issues found across 2 reviewed files. 1 file intentionally excluded from review.
Confidence score: 5/5
Automated review surfaced no issues in the provided summaries.
No files require special attention.
Auto-approved: Fixes token border colors to override Bootstrap's .border by moving them into Bootstrap's border-color utilities and setting the default border variable on body for dark mode. Bounded styling fix; dismissed finding addressed by applying color on the element.
The reason will be displayed to describe this comment to others. Learn more.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
Automated review surfaced no issues in the provided summaries.
No files require special attention.
Auto-approved: Bounded styling fix: token border colors now generate as Bootstrap border-color utilities so border border-warning wins, with the default border variable on body for dark mode. The dismissed inheritance finding is resolved since border-color applies to the element and does not inherit.
The reason will be displayed to describe this comment to others. Learn more.
0 issues found across 3 files (changes from recent commits).
Confidence score: 5/5
Automated review surfaced no issues in the provided summaries.
No files require special attention.
Auto-approved: Bounded styling fix: token border colours now generate as Bootstrap border-color utilities so border border-warning wins, plain .borders use the dark token via a body variable, and the "Currently served" box is simplified with a readOnly ValueEditor.
talissoncosta
changed the title
fix(Styles): Make token border colours work with Bootstrap's .border
fix(Styles): Make border colours apply and follow dark mode
Nov 17, 2026
talissoncosta
changed the title
fix(Styles): Make border colours apply and follow dark mode
fix(Tokens): Make border colours apply and follow dark mode
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixfront-endIssue related to the React Front End Dashboard
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
border border-warningdraws the default colour, because Bootstrap's.border(with!important) beats our token colour classes..border-*with the token colours, so they come after.borderand win.--bs-border-coloris set onbodyinstead of:root, so it follows dark mode.Visible changes: token border colours now apply (MV "Currently served" box, permission chips, segment rule warning inputs), and plain
.borders use the dark token in dark mode. The "Currently served" box, which only showed its colours with this fix, is simplified: one gold outline, the value at full strength (newreadOnlyonValueEditor), and the stale warning uses the DSBanner.How did you test this code?
Checked the computed border colours in light and dark.
Check in both themes:
mv/VariationOptions.tsx): DS warning banner, gold outline, value at full strengthPermissionsSummaryList.tsx): border turns green/gold but text stays purple, fixed in fix(Permissions): Colour the permission summary chips by access level #9004segments/Rule/components/RuleConditionValueInput.tsx,TextAreaModal.tsx): warning border, also while focusedpages/usage/components/*)charts/ChartTooltip.tsx)organisation-settings/usage/components/SingleSDKLabelsChart.tsx)pages/environment-settings/tabs/warehouse-tab/WarehouseConnectionCard.tsx)