Repository navigation
fix(Permissions): Colour the permission summary chips by access level - #9004
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Docker builds report
|
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Bounded frontend refactor: permission summary chips switch to DS Chip success/warning variants, extracting a shared chipClassName helper for tooltip markup while preserving full-access vs tag-scoped semantics.
Turn on auto-fix | Re-trigger cubic
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23388 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-16 — run #23388 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-16 — run #23388 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #23388 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ private-cloud · depot-ubuntu-latest-16 — run #23384 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23384 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #23384 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #23384 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
|
Visual Regression25 screenshots compared. See report for details. |
The base branch was changed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3b7ecc1 to
9a8c969
Compare
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Bounded frontend refactor: permission summary chips now render via DS Chip success/warning variants, with a shared chipClassName helper for the +N tooltip HTML, preserving full-access vs tag-scoped display semantics.
Turn on auto-fix | Re-trigger cubic
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
The permission summary chips meant to be green (full access) or gold (tag-scoped), but
.chipkept them purple. With #9003 the border turns green or gold while the text stays purple.Chipwith thesuccess/warningvariants.chipClassNameexported fromChip.How did you test this code?
Checked the chips in Storybook, light and dark.