Skip to content

fix(Permissions): Colour the permission summary chips by access level - #9004

Merged
talissoncosta merged 1 commit into
mainfrom
refactor/permissions-summary-chips
Nov 17, 2026
Merged

talissoncosta merged 1 commit into
mainfrom
refactor/permissions-summary-chips

Conversation

@talissoncosta

@talissoncosta talissoncosta commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

The permission summary chips meant to be green (full access) or gold (tag-scoped), but .chip kept them purple. With #9003 the border turns green or gold while the text stays purple.

  • Uses Chip with the success / warning variants.
  • The "+N" tooltip, built as an HTML string, uses chipClassName exported from Chip.

How did you test this code?

Checked the chips in Storybook, light and dark.

  • Roles or groups list with permissions, including a tag-scoped one and the "+N" tooltip

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Nov 17, 2026 8:24pm UTC
flagsmith-frontend-staging Ready Ready Preview Nov 17, 2026 8:24pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 17, 2026 8:24pm UTC

Request Review

@talissoncosta
talissoncosta requested a review from a team as a code owner November 17, 2026 19:50
@talissoncosta
talissoncosta requested review from kyle-ssg and removed request for a team November 17, 2026 19:50
@talissoncosta talissoncosta self-assigned this Nov 17, 2026
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Chip component now uses the exported chipClassName helper to build base, variant and size classes. PermissionsSummaryList uses Chip components for permissions and the truncated-count indicator. It selects the warning variant for permissions with tags and the success variant otherwise. Tooltip entries use chipClassName with the same variant selection.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · up to 9a8c9

This updates the permission summary chips to use the design-system Chip with success and warning variants. It carries little merge risk; a quick visual check of the roles or groups list and the "+N" tooltip would be sensible.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d1eb741a-0074-4704-bc84-ca08f4954226
Commits

Reviewing files that changed from the base of the PR and between 0dd2d9a and 9a8c969.

Files selected for processing: 3

  • frontend/web/components/PermissionsSummaryList.tsx
  • frontend/web/components/base/Chip/Chip.tsx
  • frontend/web/components/base/Chip/index.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-9004 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-9004 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-9004 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-9004 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-9004 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-9004 Finished ✅ Results ✅

cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Nov 17, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Bounded frontend refactor: permission summary chips switch to DS Chip success/warning variants, extracting a shared chipClassName helper for tooltip markup while preserving full-access vs tag-scoped semantics.

Turn on auto-fix | Re-trigger cubic

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23388 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 1 second
commit  9a8c969
info  🔄 Run: #23388 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-16 — run #23388 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  7 passed

Details

stats  7 tests across 5 suites
duration  7.6 seconds
commit  9a8c969
info  🔄 Run: #23388 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23388 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.2 seconds
commit  9a8c969
info  🔄 Run: #23388 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23388 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  4.3 seconds
commit  9a8c969
info  🔄 Run: #23388 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #23384 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  9.6 seconds
commit  3b7ecc1
info  🔄 Run: #23384 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23384 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  6 passed

Details

stats  6 tests across 5 suites
duration  38.1 seconds
commit  3b7ecc1
info  🔄 Run: #23384 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23384 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  34.1 seconds
commit  3b7ecc1
info  🔄 Run: #23384 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23384 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  34 seconds
commit  3b7ecc1
info  🔄 Run: #23384 (attempt 1)

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Visual Regression

25 screenshots compared. See report for details.
View full report

Base automatically changed from feat/chip-warning-variant to main November 17, 2026 20:22
@talissoncosta
talissoncosta dismissed cubic-dev-ai[bot]’s stale review November 17, 2026 20:22

The base branch was changed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Bounded frontend refactor: permission summary chips now render via DS Chip success/warning variants, with a shared chipClassName helper for the +N tooltip HTML, preserving full-access vs tag-scoped display semantics.

Turn on auto-fix | Re-trigger cubic

@talissoncosta talissoncosta changed the title refactor(Permissions): Use the DS Chip for the permission summary fix(Permissions): Colour the permission summary chips by access level Nov 17, 2026
@talissoncosta
talissoncosta merged commit 15033bd into main Nov 17, 2026
32 checks passed
@talissoncosta
talissoncosta deleted the refactor/permissions-summary-chips branch November 17, 2026 21:03

This branch was successfully deployed

2 active deployments
Preview – flagsmith-frontend-staging — 9a8c969b Deployed Nov 17, 2026 by vercel[bot]
Preview – flagsmith-frontend-preview — 9a8c969b Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant