Repository navigation
Add --lang and --clear-lang to emails generate and edit (brew-v2#2225) - #70
Merged
Merged
Conversation
thedogwiththedataonit
marked this pull request as ready for review
October 23, 2026 09:50
--lang <code> sends the body lang on emails generate and emails edit; alone on edit it is a free envelope patch. --clear-lang sends lang: null so Brew reads the language again. emails get shows lang. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thedogwiththedataonit
force-pushed
the
claude/email-lang
branch
from
October 24, 2026 18:52
ca3b8f0 to
a92a86e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to GetBrew/brew-v2#2225 (merged and deployed 10-23), which added
emails.lang: the language of an email's copy, as an ISO 639-1 code orzh-Hans/zh-Hant. Companion PRs: GetBrew/typescript-sdk#81 and GetBrew/docs#350.The vendored spec and generated types already carry
langonmain, and the published@brew.new/sdk13.3.0 types it. This PR adds the command surface:emails generate --lang <code>sends the bodylang. If you omit it, Brew detects the language from the finished body.emails edit --lang <code>sends the bodylang.langjoins the envelope fields, so--langalone is a free in-place patch: no AI run and no new version. The progress line reads "Setting the language…". A language you set is kept from then on.emails edit --clear-langsendslang: null, which clears a named language so Brew reads it again. It conflicts with--lang(exit 2), mirroring--group-id/--ungroup.emails getprints the API row as-is, solangappears. A test pins this.docs/commands/README.mdregenerated. README and CHANGELOG (Unreleased) updated.--subject-lineones: generate--lang, edit lang-only (no generation heartbeat), edit prompt + lang,--clear-lang, the--lang+--clear-langconflict, and get showslang. The write tests fail without the command changes.The flag is not checked against the enum locally. The API's
400nameslangand lists the valid codes.Checks
tsc --noEmit,biome check .anddocs:commands:checkpass.vitest run: 706/706 passing, onmainat 1daa79f.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge after the companion API change is deployed.Summary
Adds language options to email creation and editing.
No actionable issues found. Tests were inspected, not run. The previous-review guard failed because the merge bases differ, so this review covered the full PR diff.
Reviews (2) · Last reviewed commit: "Add --lang and --clear-lang to emails ge..." · Reviewed by Greptile