Repository navigation
Export EmailLanguage and document the email lang field (brew-v2#2225) - #81
Merged
Merged
Conversation
thedogwiththedataonit
force-pushed
the
claude/email-lang
branch
from
October 23, 2026 04:16
569d685 to
d632aa0
Compare
thedogwiththedataonit
marked this pull request as ready for review
October 23, 2026 09:50
The generated types already carry `lang` (13.3.0). This adds the EmailLanguage type derived from the API enum, tests for lang and lang: null on emails.edit and lang on emails.get, and the emails docs and changelog entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thedogwiththedataonit
force-pushed
the
claude/email-lang
branch
from
October 24, 2026 18:52
ff19fe8 to
a4d96df
Compare
thedogwiththedataonit
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to GetBrew/brew-v2#2225 (merged and deployed 10-23), which added
emails.lang: the language of an email's copy, as an ISO 639-1 code orzh-Hans/zh-Hant. Companion PRs: GetBrew/brew-cli#70 and GetBrew/docs#350.The spec mirror and generated types already carry
langonmain(released in 13.3.0). This PR adds what generation doesn't:EmailLanguagetype, exported from the package root. It is derived from the generatedEmailDetail['lang'], so a language the API adds arrives with the next type sync and there is no list to keep in step by hand.emails.editforwards an envelope-onlylang, andlang: null(which clears a language the caller named so Brew reads it again).emails.getreturnslang, typed asEmailLanguage, with a@ts-expect-errorfor a code outside the enum.docs/emails.md:langon the detail row,GenerateEmailInputandEditEmailInput, includingnullclearing.Checks
tsc --noEmit,eslint .,prettier --check .andtsuppass.vitest run: 764/764 passing, onmainat 4f25ad2.Production check (10-25):
get_emailreturnslang: "en"on a September design, list rows omitlang, and the HTML download starts with<html lang="en" dir="ltr">.🤖 Generated with Claude Code
The PR appears safe to merge after the related API change is deployed.Summary
Exposes
EmailLanguagefrom the SDK's existing generated API types and documents how callers set or clear an email's language.Reviews (2) · Last reviewed commit: "Document the email lang field and export..." · Reviewed by Greptile