Skip to content

Attach plugin zip to release even when tag already exists - #153

Merged
Grigory-Rylov merged 1 commit into
masterfrom
fix/plugin-release-attach
Nov 11, 2026
Merged

Grigory-Rylov merged 1 commit into
masterfrom
fix/plugin-release-attach

Conversation

@Grigory-Rylov

Copy link
Copy Markdown
Owner

Problem

On merges to master both app-build.yml and build-plugin.yml run. app-build publishes the GitHub Release for the date-based version (e.g. v26.11.11) first. The plugin workflow then saw the tag existing and skipped publishing entirely — so releases contained only app artifacts, never yamp_plugin_*.zip.

Fix

Remove the tag-exists gate and the manual tag push. softprops/action-gh-release@v2 creates the release+tag when missing and appends the asset when the release already exists — so the plugin zip always lands on the release for its version.

app-build.yml publishes the release first on master merges; the plugin
workflow then skipped publishing because its tag-exists check assumed
the tag meant 'already released'. Multiple merges share one date-based
yampVersion, so plugins never reached releases. Upload unconditionally:
softprops/action-gh-release appends the asset to an existing release.
@Grigory-Rylov
Grigory-Rylov merged commit 0da67d7 into master Nov 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant