Repository navigation
Attach plugin zip to release even when tag already exists - #153
Merged
Merged
Conversation
app-build.yml publishes the release first on master merges; the plugin workflow then skipped publishing because its tag-exists check assumed the tag meant 'already released'. Multiple merges share one date-based yampVersion, so plugins never reached releases. Upload unconditionally: softprops/action-gh-release appends the asset to an existing release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On merges to master both
app-build.ymlandbuild-plugin.ymlrun. app-build publishes the GitHub Release for the date-based version (e.g. v26.11.11) first. The plugin workflow then saw the tag existing and skipped publishing entirely — so releases contained only app artifacts, neveryamp_plugin_*.zip.Fix
Remove the tag-exists gate and the manual tag push.
softprops/action-gh-release@v2creates the release+tag when missing and appends the asset when the release already exists — so the plugin zip always lands on the release for its version.