Repository navigation
Math/ResourceStorage: Fix Tests After PHPUnit 13.4 - #12392
Merged
Merged
Conversation
See: ILIAS-eLearning@ec794e3 The checks workflow on release_12 fails since the 12.0 Beta 1 commit. The dependency update in 958865f pulled PHPUnit 13.4 and sebastian/diff 9.0, which removed UnifiedDiffOutputBuilder. The Math adapter tests built their failure message with that class, so every numeric assertion errored before comparing the values. The comparison now reports the two numbers directly and no longer depends on a PHPUnit internal class. The parameter order of assertEqualNumbers() is corrected to expected, actual. CollectionRepositoryTest expected manipulateF() twice with the same arguments. PHPUnit 13.4 rejects a second identical expectation, while CollectionDBRepository::update() calls the method only once. The duplicated expectation is removed.
mjansenDatabay
approved these changes
Nov 10, 2026
Contributor
Author
|
Hey all, Thank you for the approval. Since there is currently no authority assigned to the Math component and several other code authorities have approved the changes, I will merge them now. Kind regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: ec794e3
The checks workflow on release_12 fails since the 12.0 Beta 1 commit. The dependency update in 958865f pulled PHPUnit 13.4 and sebastian/diff 9.0, which removed UnifiedDiffOutputBuilder.
The Math adapter tests built their failure message with that class, so every numeric assertion errored before comparing the values. The comparison now reports the two numbers directly and no longer depends on a PHPUnit internal class. The parameter order of assertEqualNumbers() is corrected to expected, actual.
CollectionRepositoryTest expected manipulateF() twice with the same arguments. PHPUnit 13.4 rejects a second identical expectation, while CollectionDBRepository::update() calls the method only once. The duplicated expectation is removed.