Skip to content

Math/ResourceStorage: Fix Tests After PHPUnit 13.4 #12392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thojou merged 1 commit into from
Nov 10, 2026
Merged

Math/ResourceStorage: Fix Tests After PHPUnit 13.4 #12392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions components/ILIAS/Math/tests/ilMathBaseAdapterTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
*********************************************************************/

use PHPUnit\Framework\TestCase;
use SebastianBergmann\Diff\Differ;
use SebastianBergmann\Diff\Output\UnifiedDiffOutputBuilder;

/**
* @author Michael Jansen <mjansen@databay.de>
Expand All @@ -45,15 +43,16 @@ protected function setUp(): void
* In PHPUnit 8 the ScalarComparators uses a strict string comparison, so numbers with a different amount of trailing
* 0 decimals are not equal anymore
* @see \SebastianBergmann\Comparator\ScalarComparator
* @param string $actual
* @param string $expected
* @param string $actual
*/
private function assertEqualNumbers(string $actual, string $expected): void
private function assertEqualNumbers(string $expected, string $actual): void
{
$differ = new Differ(new UnifiedDiffOutputBuilder("\n--- Expected\n+++ Actual\n"));

/** @noinspection PhpUnitTestsInspection */
$this->assertTrue($actual == $expected, $differ->diff($actual, $expected));
$this->assertTrue(
$actual == $expected,
sprintf("Failed asserting that '%s' is numerically equal to '%s'.", $actual, $expected)
);
}

#[\PHPUnit\Framework\Attributes\DataProvider('addData')]
Expand Down
4 changes: 0 additions & 4 deletions components/ILIAS/ResourceStorage/tests/Collection/CollectionRepositoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ public function testStore(): void
->method('manipulateF')
->with('DELETE FROM il_resource_rca WHERE rcid = %s AND rid NOT IN("rid_one", "rid_one")');

$this->db_mock->expects($this->once())
->method('manipulateF')
->with('DELETE FROM il_resource_rca WHERE rcid = %s AND rid NOT IN("rid_one", "rid_one")');

$called_table_names = [
'il_resource_rca',
'il_resource_rca',
Expand Down
Loading