Repository navigation
feat(login): three-anchor redesign with antigravity-accurate particles #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fix the far-field threshold. The current assertion checks no particles.
setup()uses a 1200×800 field, soradius = ringRadius(1200, 800) = 240. The motion center is at (600, 400). The farthest grid particle is about 721 px from the center. The conditiond > radius * 4requiresd > 960, so no particle meets it.farMaxLeveltherefore stays0, andexpect(farMaxLevel).toBeLessThanOrEqual(1)on Line 108 passes for anycomputeFrameoutput. The test does not check the claim in its comment that far particles are drawn only as faint dots.You can use
radius * 2.5(600 px). The corner regions of this field are past that distance. At that distance, the envelope is about 0 andhaloFalloff * HALO_FLOORis about 0.04, so the ambient term dominates and the expected level is 0. You can also assert that at least one particle matched, so the check cannot become vacuous again.💚 Proposed fix
Declare
let farCount = 0;next tofarMaxLevel. Then add this before thefarMaxLevelassertion:🤖 Prompt for AI Agents